linux-kernel - Re: [PATCH 08/15] reset: remove unneeded include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MdC3NArnvPhHNoEOJnEfVGJVyfN6j-VgchXrkjEWiOD=Q@mail.gmail.com>
Date: Thu, 8 Jan 2026 15:13:54 +0100
From: Bartosz Golaszewski <brgl@...nel.org>
To: Philipp Zabel <p.zabel@...gutronix.de>
Cc: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>, 
	Krzysztof Kozlowski <krzk@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/15] reset: remove unneeded include

On Thu, Jan 8, 2026 at 2:59 PM Philipp Zabel <p.zabel@...gutronix.de> wrote:
>
> On Mo, 2026-01-05 at 15:15 +0100, Bartosz Golaszewski wrote:
> > Reset core does not use any symbols from linux/of_platform.h so there's
> > no need to include it.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>
> > ---
> >  drivers/reset/core.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> > index ffb811cbc6460b48dd833d3560d6538eea2fd5c0..48eb64654b6de08030674ce3b994021b5f57060e 100644
> > --- a/drivers/reset/core.c
> > +++ b/drivers/reset/core.c
> > @@ -20,7 +20,6 @@
> >  #include <linux/kref.h>
> >  #include <linux/module.h>
> >  #include <linux/of.h>
> > -#include <linux/of_platform.h>
>
> You added this in patch 2. Can this be squashed into patch 2? Otherwise
> squash it into whichever patch makes that addition unnecessary, please.
>

Gah! Should have git blamed it before complaining. :) Thanks for the catch.

Bartosz