linux-kernel - Re: [PATCH v6 0/4] apei/ghes: don't OOPS with bad ARM error CPER records

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXGxcOAEVQUUkFDtwqGojDrNNghthcys8qQynK==jbJ9eg@mail.gmail.com>
Date: Thu, 8 Jan 2026 13:08:55 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Robert Moore <robert.moore@...el.com>, 
	acpica-devel@...ts.linux.dev, linux-acpi@...r.kernel.org, 
	linux-edac@...r.kernel.org, linux-efi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Ankit Agrawal <ankita@...dia.com>, 
	Borislav Petkov <bp@...en8.de>, Breno Leitao <leitao@...ian.org>, 
	Dan Williams <dan.j.williams@...el.com>, Dave Jiang <dave.jiang@...el.com>, 
	Hanjun Guo <guohanjun@...wei.com>, Huang Yiwei <quic_hyiwei@...cinc.com>, 
	Ira Weiny <ira.weiny@...el.com>, Jason Tian <jason@...amperecomputing.com>, 
	Jonathan Cameron <jonathan.cameron@...wei.com>, Len Brown <lenb@...nel.org>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Shuai Xue <xueshuai@...ux.alibaba.com>, 
	Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>, Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH v6 0/4] apei/ghes: don't OOPS with bad ARM error CPER records

On Thu, 8 Jan 2026 at 12:35, Mauro Carvalho Chehab
<mchehab+huawei@...nel.org> wrote:
>
> Rafael,
>
> Current parsing logic at apei/ghes for ARM Processor Error
> assumes that the record sizes are correct. Yet, a bad BIOS
> might produce malformed GHES reports.
>
> Worse than that, it may end exposing data from other memory
> addresses, as the logic may end dumping large portions of
> the memory.
>
> Avoid that by checking the buffer sizes where needed.
>
> ---
>
> v6:
>  - No code changes, just a cosmetic change at patch 3 description
>  - Added Jonathan's review on all patches
>
> v5:
>  - Changed the name of a var as requested by Jonathan
>
> v4:
>  - addressed Jonathan comments;
>  - added two extra patches to prevent other OOM issues.
>
> v3:
>   - addressed Shuai feedback;
>   - moved all ghes code to one patch;
>   - fixed a typo and a bad indent;
>   - cleanup the size check logic at ghes.c.
>
> Mauro Carvalho Chehab (4):
>   apei/ghes: ARM processor Error: don't go past allocated memory
>   efi/cper: don't go past the ARM processor CPER record buffer
>   apei/ghes: ensure that won't go past CPER allocated record
>   efi/cper: don't dump the entire memory region
>

I've skimmed over this and it all looks reasonable to me

Acked-by: Ard Biesheuvel <ardb@...nel.org>

Thanks for cleaning this up.