linux-kernel - Re: [PATCH 1/6] nfs: properly disallow delegation requests on directories

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aV93y-xeWk16s48r@infradead.org>
Date: Thu, 8 Jan 2026 01:24:27 -0800
From: Christoph Hellwig <hch@...radead.org>
To: Jeff Layton <jlayton@...nel.org>
Cc: Christian Brauner <brauner@...nel.org>,
	Al Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>,
	Steve French <sfrench@...ba.org>,
	Paulo Alcantara <pc@...guebit.org>,
	Ronnie Sahlberg <ronniesahlberg@...il.com>,
	Shyam Prasad N <sprasad@...rosoft.com>, Tom Talpey <tom@...pey.com>,
	Bharath SM <bharathsm@...rosoft.com>,
	Trond Myklebust <trondmy@...nel.org>,
	Anna Schumaker <anna@...nel.org>,
	Eric Van Hensbergen <ericvh@...nel.org>,
	Latchesar Ionkov <lucho@...kov.net>,
	Dominique Martinet <asmadeus@...ewreck.org>,
	Christian Schoenebeck <linux_oss@...debyte.com>,
	Andreas Gruenbacher <agruenba@...hat.com>,
	Xiubo Li <xiubli@...hat.com>, Ilya Dryomov <idryomov@...il.com>,
	Hans de Goede <hansg@...nel.org>, NeilBrown <neil@...wn.name>,
	Christoph Hellwig <hch@...radead.org>, linux-cifs@...r.kernel.org,
	samba-technical@...ts.samba.org, linux-kernel@...r.kernel.org,
	linux-nfs@...r.kernel.org, v9fs@...ts.linux.dev,
	gfs2@...ts.linux.dev, ceph-devel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 1/6] nfs: properly disallow delegation requests on
 directories

On Wed, Jan 07, 2026 at 09:20:09AM -0500, Jeff Layton wrote:
> Checking for S_ISREG() in nfs4_setlease() is incorrect, since that op is
> never called for directories. The right way to deny lease requests on
> directories is to set the ->setlease() operation to simple_nosetlease()
> in the directory file_operations.

This fixes generic/786 on NFSv4.2 for me, so:

Tested-by: Christoph Hellwig <hch@....de>