linux-kernel - Re: [PATCH v2] arch/sparc: fix unused variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da4e67bf-e671-46a6-8b09-19193c747c37@gmail.com>
Date: Thu, 8 Jan 2026 09:26:28 +0800
From: Alex Shi <seakeel@...il.com>
To: Matthew Wilcox <willy@...radead.org>, alexs@...nel.org
Cc: "David S. Miller" <davem@...emloft.net>,
 Andreas Larsson <andreas@...sler.com>,
 "open list:SPARC + UltraSPARC (sparc/sparc64)" <sparclinux@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>, kernel test robot <lkp@...el.com>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 Qi Zheng <zhengqi.arch@...edance.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>, Zi Yan <ziy@...dia.com>,
 Kevin Brodsky <kevin.brodsky@....com>, Mike Rapoport <rppt@...nel.org>,
 Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2] arch/sparc: fix unused variable warning

On 2026/1/7 22:46, Matthew Wilcox wrote:
> On Wed, Jan 07, 2026 at 06:41:44PM +0800,alexs@...nel.org wrote:
>> From: Alex Shi<alexs@...nel.org>
>>
>>     arch/sparc/mm/init_64.c: In function 'arch_hugetlb_valid_size':
>>     arch/sparc/mm/init_64.c:361:24: warning: variable 'hv_pgsz_idx' set but not used [-Wunused-but-set-variable]
>>       361 |         unsigned short hv_pgsz_idx;
>>           |                        ^~~~~~~~~~~
> Looks like it's been unused since introduction in c7d9f77d33a7 ?
> 
> As such, why cc all these people who have absolutely nothing to do with
> it?  Use your brain, not a stupid script.

Thanks for the feedback, Matthew. You're right—the script was too 
aggressive for such a localized fix.

I used 'scripts/get_maintainer.pl' without enough manual filtering. 
Besides '--nogit-fallback', are there specific parameters or workflows 
you recommend to keep the CC list lean for trivial cleanups like this?

I'll be more surgical with the CC list on the next version.

Thanks!