linux-kernel - Re: [PATCH] cxl/pci: Remove outdated FIXME comment and BUILD_BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260108162035.00002c56@huawei.com>
Date: Thu, 8 Jan 2026 16:20:35 +0000
From: Jonathan Cameron <jonathan.cameron@...wei.com>
To: Dave Jiang <dave.jiang@...el.com>
CC: Samasth Norway Ananda <samasth.norway.ananda@...cle.com>,
	<dave@...olabs.net>, <lison.schofield@...el.com>, <vishal.l.verma@...el.com>,
	<ira.weiny@...el.com>, <dan.j.williams@...el.com>,
	<linux-cxl@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cxl/pci: Remove outdated FIXME comment and BUILD_BUG_ON

On Tue, 6 Jan 2026 10:55:13 -0700
Dave Jiang <dave.jiang@...el.com> wrote:

> On 1/5/26 1:38 PM, Samasth Norway Ananda wrote:
> > Remove the outdated FIXME comment about switching to struct_group() and
> > the associated BUILD_BUG_ON check. This work was already completed in
> > commit 301e68dd9b9b ("cxl/core: Replace unions with struct_group()")
> > which converted struct cxl_regs to use struct_group_tagged().
> > 
> > The BUILD_BUG_ON was checking that anonymous union layout was preserved,
> > but since struct_group() now handles this correctly, the compile-time
> > check is no longer necessary.
> > 
> > Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@...cle.com>  
> 
> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>