| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <875x9c3rej.fsf@mail.parknet.co.jp>
Date: Fri, 09 Jan 2026 03:12:20 +0900
From: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To: Jeff Layton <jlayton@...nel.org>
Cc: Luis de Bethencourt <luisbg@...nel.org>,
Salah Triki
<salah.triki@...il.com>, Nicolas Pitre <nico@...xnic.net>,
Christoph
Hellwig <hch@...radead.org>, Jan Kara <jack@...e.cz>,
Anders Larsen
<al@...rsen.net>,
Alexander Viro <viro@...iv.linux.org.uk>,
Christian
Brauner <brauner@...nel.org>,
David Sterba <dsterba@...e.com>, Chris
Mason <clm@...com>,
Gao Xiang <xiang@...nel.org>, Chao Yu
<chao@...nel.org>,
Yue Hu <zbestahu@...il.com>, Jeffle Xu
<jefflexu@...ux.alibaba.com>,
Sandeep Dhavale <dhavale@...gle.com>,
Hongbo Li <lihongbo22@...wei.com>, Chunhai Guo <guochunhai@...o.com>,
Jan Kara <jack@...e.com>, "Theodore Ts'o" <tytso@....edu>,
Andreas Dilger
<adilger.kernel@...ger.ca>,
Jaegeuk Kim <jaegeuk@...nel.org>,
David
Woodhouse <dwmw2@...radead.org>,
Richard Weinberger <richard@....at>, Dave Kleikamp <shaggy@...nel.org>,
Ryusuke Konishi
<konishi.ryusuke@...il.com>,
Viacheslav Dubeyko <slava@...eyko.com>,
Konstantin Komarov <almaz.alexandrovich@...agon-software.com>,
Mark
Fasheh <mark@...heh.com>, Joel Becker <jlbec@...lplan.org>,
Joseph Qi
<joseph.qi@...ux.alibaba.com>,
Mike Marshall <hubcap@...ibond.com>,
Martin Brandenburg <martin@...ibond.com>,
Miklos Szeredi
<miklos@...redi.hu>,
Amir Goldstein <amir73il@...il.com>,
Phillip
Lougher <phillip@...ashfs.org.uk>,
Carlos Maiolino <cem@...nel.org>, Hugh Dickins <hughd@...gle.com>,
Baolin Wang
<baolin.wang@...ux.alibaba.com>,
Andrew Morton
<akpm@...ux-foundation.org>,
Namjae Jeon <linkinjeon@...nel.org>,
Sungjong Seo <sj1557.seo@...sung.com>,
Yuezhang Mo
<yuezhang.mo@...y.com>,
Chuck Lever <chuck.lever@...cle.com>,
Alexander
Aring <alex.aring@...il.com>,
Andreas Gruenbacher <agruenba@...hat.com>,
Jonathan Corbet <corbet@....net>,
"Matthew Wilcox (Oracle)"
<willy@...radead.org>,
Eric Van Hensbergen <ericvh@...nel.org>,
Latchesar Ionkov <lucho@...kov.net>,
Dominique Martinet
<asmadeus@...ewreck.org>,
Christian Schoenebeck
<linux_oss@...debyte.com>,
Xiubo Li <xiubli@...hat.com>, Ilya Dryomov
<idryomov@...il.com>,
Trond Myklebust <trondmy@...nel.org>,
Anna
Schumaker <anna@...nel.org>, Steve French <sfrench@...ba.org>,
Paulo
Alcantara <pc@...guebit.org>,
Ronnie Sahlberg <ronniesahlberg@...il.com>,
Shyam Prasad N <sprasad@...rosoft.com>, Tom Talpey <tom@...pey.com>,
Bharath SM <bharathsm@...rosoft.com>, Hans de Goede <hansg@...nel.org>,
linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
linux-btrfs@...r.kernel.org, linux-erofs@...ts.ozlabs.org,
linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net,
linux-mtd@...ts.infradead.org, jfs-discussion@...ts.sourceforge.net,
linux-nilfs@...r.kernel.org, ntfs3@...ts.linux.dev,
ocfs2-devel@...ts.linux.dev, devel@...ts.orangefs.org,
linux-unionfs@...r.kernel.org, linux-xfs@...r.kernel.org,
linux-mm@...ck.org, gfs2@...ts.linux.dev, linux-doc@...r.kernel.org,
v9fs@...ts.linux.dev, ceph-devel@...r.kernel.org,
linux-nfs@...r.kernel.org, linux-cifs@...r.kernel.org,
samba-technical@...ts.samba.org
Subject: Re: [PATCH 09/24] fat: add setlease file operation
Jeff Layton <jlayton@...nel.org> writes:
> Add the setlease file_operation to fat_file_operations and
> fat_dir_operations, pointing to generic_setlease. A future patch will
> change the default behavior to reject lease attempts with -EINVAL when
> there is no setlease file operation defined. Add generic_setlease to
> retain the ability to set leases on this filesystem.
>
> Signed-off-by: Jeff Layton <jlayton@...nel.org>
Looks good.
Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
> ---
> fs/fat/dir.c | 2 ++
> fs/fat/file.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index 92b091783966af6a9e6f5ead1a382a98dd92bba0..807bc8b1bc145a9f15765920670c6233f7e87e55 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -16,6 +16,7 @@
>
> #include <linux/slab.h>
> #include <linux/compat.h>
> +#include <linux/filelock.h>
> #include <linux/uaccess.h>
> #include <linux/iversion.h>
> #include "fat.h"
> @@ -876,6 +877,7 @@ const struct file_operations fat_dir_operations = {
> .compat_ioctl = fat_compat_dir_ioctl,
> #endif
> .fsync = fat_file_fsync,
> + .setlease = generic_setlease,
> };
>
> static int fat_get_short_entry(struct inode *dir, loff_t *pos,
> diff --git a/fs/fat/file.c b/fs/fat/file.c
> index 4fc49a614fb8fd64e219db60c6d9e7dd100aea1c..d50a6d8bfaae0c75b2dbe838d108135206d0f123 100644
> --- a/fs/fat/file.c
> +++ b/fs/fat/file.c
> @@ -13,6 +13,7 @@
> #include <linux/mount.h>
> #include <linux/blkdev.h>
> #include <linux/backing-dev.h>
> +#include <linux/filelock.h>
> #include <linux/fsnotify.h>
> #include <linux/security.h>
> #include <linux/falloc.h>
> @@ -212,6 +213,7 @@ const struct file_operations fat_file_operations = {
> .splice_read = filemap_splice_read,
> .splice_write = iter_file_splice_write,
> .fallocate = fat_fallocate,
> + .setlease = generic_setlease,
> };
>
> static int fat_cont_expand(struct inode *inode, loff_t size)
--
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Powered by blists - more mailing lists