| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20260108181612.2340796-4-samasth.norway.ananda@oracle.com> Date: Thu, 8 Jan 2026 10:16:11 -0800 From: Samasth Norway Ananda <samasth.norway.ananda@...cle.com> To: dan.carpenter@...aro.org, gregkh@...uxfoundation.org Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org Subject: [PATCH v2 3/3] staging: rtl8723bs: add IS_ERR() check for kthread_run() kthread_run() returns an ERR_PTR on failure, not NULL. Without this check, rtl8723b_stop_thread() would later check "if (xmitpriv->SdioXmitThread)" which evaluates to true for error pointers, potentially causing issues when trying to complete or wait on an invalid thread. Set the pointer to NULL on failure to prevent later code from attempting to use an invalid thread pointer. Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@...cle.com> --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index 56ceedd5a26a..27d490204fcc 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -2922,6 +2922,8 @@ void rtl8723b_start_thread(struct adapter *padapter) struct xmit_priv *xmitpriv = &padapter->xmitpriv; xmitpriv->SdioXmitThread = kthread_run(rtl8723bs_xmit_thread, padapter, "RTWHALXT"); + if (IS_ERR(xmitpriv->SdioXmitThread)) + xmitpriv->SdioXmitThread = NULL } void rtl8723b_stop_thread(struct adapter *padapter) -- 2.50.1
Powered by blists - more mailing lists