linux-kernel - RE: [PATCH v2 7/8] arm64: dts: renesas: r9a09g077m44-rzt2h-evk: add GPIO keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYRPR01MB156196B6A2C6808841B5BAF818585A@TYRPR01MB15619.jpnprd01.prod.outlook.com>
Date: Thu, 8 Jan 2026 18:27:55 +0000
From: Cosmin-Gabriel Tanislav <cosmin-gabriel.tanislav.xa@...esas.com>
To: geert <geert@...ux-m68k.org>
CC: Linus Walleij <linusw@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	magnus.damm <magnus.damm@...il.com>, Prabhakar Mahadev Lad
	<prabhakar.mahadev-lad.rj@...renesas.com>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 7/8] arm64: dts: renesas: r9a09g077m44-rzt2h-evk: add
 GPIO keys

> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Sent: Thursday, January 8, 2026 8:08 PM
> 
> Hi Cosmin,
> 
> On Fri, 5 Dec 2025 at 16:04, Cosmin Tanislav
> <cosmin-gabriel.tanislav.xa@...esas.com> wrote:
> > The Renesas RZ/T2H Evaluation Kit has three user buttons connected to
> > GPIOs that can be used as input keys.
> >
> > Add support for them.
> >
> > Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@...esas.com>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/r9a09g077m44-rzt2h-evk.dts
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g077m44-rzt2h-evk.dts
> > @@ -7,6 +7,8 @@
> >
> >  /dts-v1/;
> >
> > +#include <dt-bindings/input/input.h>
> > +
> >  #include "r9a09g077m44.dtsi"
> >
> >  /*
> > @@ -60,6 +62,37 @@ / {
> >         model = "Renesas RZ/T2H EVK Board based on r9a09g077m44";
> >         compatible = "renesas,rzt2h-evk", "renesas,r9a09g077m44", "renesas,r9a09g077";
> >
> > +       keys {
> > +               compatible = "gpio-keys";
> > +
> > +#if (!SD1_MICRO_SD)
> > +               /* SW2-3: ON */
> 
> Shouldn't that be OFF?
> 

Good catch! Yes, it should be OFF, as it's ON for SD Card.

I will fix it for the next version.

> > +               key-1 {
> > +                       interrupts-extended = <&pinctrl RZT2H_GPIO(8, 6) IRQ_TYPE_EDGE_FALLING>;
> > +                       linux,code = <KEY_1>;
> > +                       label = "SW9";
> > +                       wakeup-source;
> > +                       debounce-interval = <20>;
> > +               };
> > +#endif
> 
> The rest LGTM.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds