linux-kernel - Re: [PATCH] drm/xe: fix WQ_MEM_RECLAIM passed as max_active to alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aV/5KRqR6zma/ZnR@lstrano-desk.jf.intel.com>
Date: Thu, 8 Jan 2026 10:36:25 -0800
From: Matthew Brost <matthew.brost@...el.com>
To: Marco Crivellari <marco.crivellari@...e.com>
CC: <linux-kernel@...r.kernel.org>, <intel-xe@...ts.freedesktop.org>,
	<dri-devel@...ts.freedesktop.org>, Tejun Heo <tj@...nel.org>, Lai Jiangshan
	<jiangshanlai@...il.com>, Frederic Weisbecker <frederic@...nel.org>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Michal Hocko
	<mhocko@...e.com>, Thomas Hellstrom <thomas.hellstrom@...ux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@...el.com>, David Airlie <airlied@...il.com>,
	Simona Vetter <simona@...ll.ch>, <stable@...r.kernel.org>
Subject: Re: [PATCH] drm/xe: fix WQ_MEM_RECLAIM passed as max_active to
 alloc_workqueue()

On Thu, Jan 08, 2026 at 07:01:48PM +0100, Marco Crivellari wrote:
> Workqueue xe-ggtt-wq has been allocated using WQ_MEM_RECLAIM, but
> the flag has been passed as 3rd parameter (max_active) instead
> of 2nd (flags) creating the workqueue as per-cpu with max_active = 8
> (the WQ_MEM_RECLAIM value).
> 
> So change this by set WQ_MEM_RECLAIM as the 2nd parameter with a
> default max_active.
> 

Yikes - thanks for the fix. Will apply our tree shortly.

With that:
Reviewed-by: Matthew Brost <matthew.brost@...el.com>

> Fixes: 60df57e496e4 ("drm/xe: Mark GGTT work queue with WQ_MEM_RECLAIM")
> Cc: stable@...r.kernel.org
> Signed-off-by: Marco Crivellari <marco.crivellari@...e.com>
> ---
>  drivers/gpu/drm/xe/xe_ggtt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
> index ef481b334af4..793d7324a395 100644
> --- a/drivers/gpu/drm/xe/xe_ggtt.c
> +++ b/drivers/gpu/drm/xe/xe_ggtt.c
> @@ -322,7 +322,7 @@ int xe_ggtt_init_early(struct xe_ggtt *ggtt)
>  	else
>  		ggtt->pt_ops = &xelp_pt_ops;
>  
> -	ggtt->wq = alloc_workqueue("xe-ggtt-wq", 0, WQ_MEM_RECLAIM);
> +	ggtt->wq = alloc_workqueue("xe-ggtt-wq", WQ_MEM_RECLAIM, 0);
>  	if (!ggtt->wq)
>  		return -ENOMEM;
>  
> -- 
> 2.52.0
>