linux-kernel - Re: [PATCH v1 2/2] vfio/nvgrace-gpu: register device memory for poison handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SA1PR12MB7199A597C97F6A0DD4413799B085A@SA1PR12MB7199.namprd12.prod.outlook.com>
Date: Thu, 8 Jan 2026 19:21:22 +0000
From: Ankit Agrawal <ankita@...dia.com>
To: Jiaqi Yan <jiaqiyan@...gle.com>
CC: Vikram Sethi <vsethi@...dia.com>, Jason Gunthorpe <jgg@...dia.com>, Matt
 Ochs <mochs@...dia.com>, "jgg@...pe.ca" <jgg@...pe.ca>, Shameer Kolothum
	<skolothumtho@...dia.com>, "alex@...zbot.org" <alex@...zbot.org>,
	"linmiaohe@...wei.com" <linmiaohe@...wei.com>, "nao.horiguchi@...il.com"
	<nao.horiguchi@...il.com>, Neo Jia <cjia@...dia.com>, Zhi Wang
	<zhiw@...dia.com>, Krishnakant Jaju <kjaju@...dia.com>, Yishai Hadas
	<yishaih@...dia.com>, "kevin.tian@...el.com" <kevin.tian@...el.com>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [PATCH v1 2/2] vfio/nvgrace-gpu: register device memory for
 poison handling

>> +static inline
>> +struct nvgrace_gpu_pci_core_device *vma_to_nvdev(struct vm_area_struct *vma);
>
> Any reason not to define vma_to_nvdev() here directly, but later?

Actually since it uses nvgrace_gpu_vfio_pci_mmap_ops; which the compiler
complains to be undeclared if vma_to_nvdev is moved up.

>> +       ret = register_pfn_address_space(&region->pfn_address_space);
>> +
>> +       return ret;
>
> nit: I believe "ret" is unnecessary here.

Yes, I'll address that.