linux-kernel - Re: [PATCH 12/24] jfs: add setlease file operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e16a8bff-9192-45fa-a349-79b16fdd3ba5@oracle.com>
Date: Thu, 8 Jan 2026 13:46:27 -0600
From: Dave Kleikamp <dave.kleikamp@...cle.com>
To: Jeff Layton <jlayton@...nel.org>, Luis de Bethencourt
 <luisbg@...nel.org>,
        Salah Triki <salah.triki@...il.com>, Nicolas Pitre <nico@...xnic.net>,
        Christoph Hellwig <hch@...radead.org>, Jan Kara <jack@...e.cz>,
        Anders Larsen <al@...rsen.net>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>,
        David Sterba <dsterba@...e.com>, Chris Mason <clm@...com>,
        Gao Xiang <xiang@...nel.org>, Chao Yu <chao@...nel.org>,
        Yue Hu <zbestahu@...il.com>, Jeffle Xu <jefflexu@...ux.alibaba.com>,
        Sandeep Dhavale
 <dhavale@...gle.com>,
        Hongbo Li <lihongbo22@...wei.com>, Chunhai Guo <guochunhai@...o.com>,
        Jan Kara <jack@...e.com>, Theodore Ts'o <tytso@....edu>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        Jaegeuk Kim <jaegeuk@...nel.org>,
        OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
        David Woodhouse <dwmw2@...radead.org>,
        Richard Weinberger <richard@....at>, Dave Kleikamp <shaggy@...nel.org>,
        Ryusuke Konishi <konishi.ryusuke@...il.com>,
        Viacheslav Dubeyko <slava@...eyko.com>,
        Konstantin Komarov <almaz.alexandrovich@...agon-software.com>,
        Mark Fasheh <mark@...heh.com>, Joel Becker <jlbec@...lplan.org>,
        Joseph Qi <joseph.qi@...ux.alibaba.com>,
        Mike Marshall
 <hubcap@...ibond.com>,
        Martin Brandenburg <martin@...ibond.com>,
        Miklos Szeredi <miklos@...redi.hu>,
        Amir Goldstein <amir73il@...il.com>,
        Phillip Lougher <phillip@...ashfs.org.uk>,
        Carlos Maiolino <cem@...nel.org>, Hugh Dickins <hughd@...gle.com>,
        Baolin Wang
 <baolin.wang@...ux.alibaba.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Namjae Jeon <linkinjeon@...nel.org>,
        Sungjong Seo <sj1557.seo@...sung.com>,
        Yuezhang Mo <yuezhang.mo@...y.com>,
        Chuck Lever <chuck.lever@...cle.com>,
        Alexander Aring <alex.aring@...il.com>,
        Andreas Gruenbacher <agruenba@...hat.com>,
        Jonathan Corbet <corbet@....net>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Eric Van Hensbergen <ericvh@...nel.org>,
        Latchesar Ionkov
 <lucho@...kov.net>,
        Dominique Martinet <asmadeus@...ewreck.org>,
        Christian Schoenebeck <linux_oss@...debyte.com>,
        Xiubo Li
 <xiubli@...hat.com>, Ilya Dryomov <idryomov@...il.com>,
        Trond Myklebust <trondmy@...nel.org>, Anna Schumaker <anna@...nel.org>,
        Steve French <sfrench@...ba.org>, Paulo Alcantara <pc@...guebit.org>,
        Ronnie Sahlberg <ronniesahlberg@...il.com>,
        Shyam Prasad N <sprasad@...rosoft.com>, Tom Talpey <tom@...pey.com>,
        Bharath SM <bharathsm@...rosoft.com>, Hans de Goede <hansg@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-btrfs@...r.kernel.org, linux-erofs@...ts.ozlabs.org,
        linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net,
        linux-mtd@...ts.infradead.org, jfs-discussion@...ts.sourceforge.net,
        linux-nilfs@...r.kernel.org, ntfs3@...ts.linux.dev,
        ocfs2-devel@...ts.linux.dev, devel@...ts.orangefs.org,
        linux-unionfs@...r.kernel.org, linux-xfs@...r.kernel.org,
        linux-mm@...ck.org, gfs2@...ts.linux.dev, linux-doc@...r.kernel.org,
        v9fs@...ts.linux.dev, ceph-devel@...r.kernel.org,
        linux-nfs@...r.kernel.org, linux-cifs@...r.kernel.org,
        samba-technical@...ts.samba.org
Subject: Re: [PATCH 12/24] jfs: add setlease file operation

Reviewed-by: Dave Kleikamp <dave.kleikamp@...cle.com>


On 1/8/26 11:13AM, Jeff Layton wrote:
> Add the setlease file_operation to jfs_file_operations and
> jfs_dir_operations, pointing to generic_setlease.  A future patch will
> change the default behavior to reject lease attempts with -EINVAL when
> there is no setlease file operation defined. Add generic_setlease to
> retain the ability to set leases on this filesystem.
> 
> Signed-off-by: Jeff Layton <jlayton@...nel.org>
> ---
>   fs/jfs/file.c  | 2 ++
>   fs/jfs/namei.c | 2 ++
>   2 files changed, 4 insertions(+)
> 
> diff --git a/fs/jfs/file.c b/fs/jfs/file.c
> index 87ad042221e78959200cce12a59a3ffd6d06c0d7..246568cb9a6ec144831eb3592712cce323d8cf1d 100644
> --- a/fs/jfs/file.c
> +++ b/fs/jfs/file.c
> @@ -6,6 +6,7 @@
>   
>   #include <linux/mm.h>
>   #include <linux/fs.h>
> +#include <linux/filelock.h>
>   #include <linux/posix_acl.h>
>   #include <linux/quotaops.h>
>   #include "jfs_incore.h"
> @@ -153,4 +154,5 @@ const struct file_operations jfs_file_operations = {
>   	.release	= jfs_release,
>   	.unlocked_ioctl = jfs_ioctl,
>   	.compat_ioctl	= compat_ptr_ioctl,
> +	.setlease	= generic_setlease,
>   };
> diff --git a/fs/jfs/namei.c b/fs/jfs/namei.c
> index 65a218eba8faf9508f5727515b812f6de2661618..f7e2ae7a4c37ed87675f0ccb3276b37e6ce08cb4 100644
> --- a/fs/jfs/namei.c
> +++ b/fs/jfs/namei.c
> @@ -5,6 +5,7 @@
>    */
>   
>   #include <linux/fs.h>
> +#include <linux/filelock.h>
>   #include <linux/namei.h>
>   #include <linux/ctype.h>
>   #include <linux/quotaops.h>
> @@ -1545,6 +1546,7 @@ const struct file_operations jfs_dir_operations = {
>   	.unlocked_ioctl = jfs_ioctl,
>   	.compat_ioctl	= compat_ptr_ioctl,
>   	.llseek		= generic_file_llseek,
> +	.setlease	= generic_setlease,
>   };
>   
>   static int jfs_ci_hash(const struct dentry *dir, struct qstr *this)
>