linux-kernel - Re: [RESEND][PATCH v1] media: mediatek: vcodec: Discard pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aa5536613a517caf5e954e94435f1a2229bad877.camel@ndufresne.ca>
Date: Thu, 08 Jan 2026 14:51:47 -0500
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: "Rafael J. Wysocki" <rafael@...nel.org>, Linux PM
 <linux-pm@...r.kernel.org>, 	linux-media@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Ulf Hansson
 <ulf.hansson@...aro.org>,  Brian Norris <briannorris@...omium.org>, Tiffany
 Lin <tiffany.lin@...iatek.com>, Andrew-CT Chen	
 <andrew-ct.chen@...iatek.com>, Yunfei Dong <yunfei.dong@...iatek.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Matthias Brugger
 <matthias.bgg@...il.com>, AngeloGioacchino Del Regno	
 <angelogioacchino.delregno@...labora.com>,
 linux-mediatek@...ts.infradead.org
Subject: Re: [RESEND][PATCH v1] media: mediatek: vcodec: Discard
 pm_runtime_put() return value

Le jeudi 08 janvier 2026 à 16:23 +0100, Rafael J. Wysocki a écrit :
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Printing error messages on pm_runtime_put() returning negative values
> is not particularly useful.
> 
> Returning an error code from pm_runtime_put() merely means that it has
> not queued up a work item to check whether or not the device can be
> suspended and there are many perfectly valid situations in which that
> can happen, like after writing "on" to the devices' runtime PM "control"
> attribute in sysfs for one example.
> 
> Accordingly, update mtk_vcodec_enc_pw_off() and mtk_vcodec_dec_pw_off()
> to simply discard the return value of pm_runtime_put().
> 
> This will facilitate a planned change of the pm_runtime_put() return
> type to void in the future.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>

> ---
> 
> This is requisite for converting pm_runtime_put() into a void function.
> 
> If you decide to pick it up, please let me know.
> 
> Otherwise, an ACK or equivalent will be appreciated, but also the lack
> of specific criticism will be eventually regarded as consent.
> 
> Originally posted here:
> 
> https://lore.kernel.org/linux-pm/3690736.iIbC2pHGDl@rafael.j.wysocki/
> 
> ---
>  drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_pm.c |    6 +--
> ---
>  drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_pm.c |    6 +--
> ---
>  2 files changed, 2 insertions(+), 10 deletions(-)
> 
> --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_pm.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_pm.c
> @@ -67,11 +67,7 @@ static int mtk_vcodec_dec_pw_on(struct m
>  
>  static void mtk_vcodec_dec_pw_off(struct mtk_vcodec_pm *pm)
>  {
> -	int ret;
> -
> -	ret = pm_runtime_put(pm->dev);
> -	if (ret && ret != -EAGAIN)
> -		dev_err(pm->dev, "pm_runtime_put fail %d", ret);
> +	pm_runtime_put(pm->dev);
>  }
>  
>  static void mtk_vcodec_dec_clock_on(struct mtk_vcodec_pm *pm)
> --- a/drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_pm.c
> +++ b/drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_pm.c
> @@ -71,11 +71,7 @@ int mtk_vcodec_enc_pw_on(struct mtk_vcod
>  
>  void mtk_vcodec_enc_pw_off(struct mtk_vcodec_pm *pm)
>  {
> -	int ret;
> -
> -	ret = pm_runtime_put(pm->dev);
> -	if (ret && ret != -EAGAIN)
> -		dev_err(pm->dev, "pm_runtime_put fail %d", ret);
> +	pm_runtime_put(pm->dev);
>  }
>  
>  void mtk_vcodec_enc_clock_on(struct mtk_vcodec_pm *pm)
> 
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)