| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202601090436.WkXlP76u-lkp@intel.com>
Date: Fri, 09 Jan 2026 04:32:29 +0800
From: kernel test robot <lkp@...el.com>
To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: drivers/tty/serial/8250/8250_port.c:2572:2: error: cleanup
argument not a function
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 5572ad8fddecd4a0db19801262072ff5916b7589
commit: b339809edda15939e7d46b429c420c2bfe4ad946 serial: 8250: use guard()s
date: 5 months ago
config: mips-randconfig-r051-20260108 (https://download.01.org/0day-ci/archive/20260109/202601090436.WkXlP76u-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 10.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260109/202601090436.WkXlP76u-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601090436.WkXlP76u-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/cpumask.h:10,
from include/linux/smp.h:13,
from arch/mips/include/asm/cpu-type.h:12,
from arch/mips/include/asm/timex.h:19,
from include/linux/timex.h:67,
from include/linux/time32.h:13,
from include/linux/time.h:60,
from include/linux/stat.h:19,
from include/linux/module.h:13,
from drivers/tty/serial/8250/8250_port.c:14:
drivers/tty/serial/8250/8250_port.c: In function 'serial8250_update_uartclk':
>> include/linux/cleanup.h:290:2: error: unknown type name 'class_tty_port_tty_t'; did you mean 'class_uart_port_lock_t'?
290 | class_##_name##_t var __cleanup(class_##_name##_destructor) = \
| ^~~~~~
include/linux/cleanup.h:420:7: note: in expansion of macro 'CLASS'
420 | for (CLASS(_name, scope)(args); \
| ^~~~~
include/linux/cleanup.h:429:2: note: in expansion of macro '__scoped_guard'
429 | __scoped_guard(_name, __UNIQUE_ID(label), args)
| ^~~~~~~~~~~~~~
drivers/tty/serial/8250/8250_port.c:2572:2: note: in expansion of macro 'scoped_guard'
2572 | scoped_guard(tty_port_tty, tport) {
| ^~~~~~~~~~~~
>> drivers/tty/serial/8250/8250_port.c:2572:2: error: cleanup argument not a function
In file included from include/linux/cpumask.h:10,
from include/linux/smp.h:13,
from arch/mips/include/asm/cpu-type.h:12,
from arch/mips/include/asm/timex.h:19,
from include/linux/timex.h:67,
from include/linux/time32.h:13,
from include/linux/time.h:60,
from include/linux/stat.h:19,
from include/linux/module.h:13,
from drivers/tty/serial/8250/8250_port.c:14:
>> include/linux/cleanup.h:291:3: error: implicit declaration of function 'class_tty_port_tty_constructor'; did you mean 'class_uart_port_lock_constructor'? [-Werror=implicit-function-declaration]
291 | class_##_name##_constructor
| ^~~~~~
include/linux/cleanup.h:420:7: note: in expansion of macro 'CLASS'
420 | for (CLASS(_name, scope)(args); \
| ^~~~~
include/linux/cleanup.h:429:2: note: in expansion of macro '__scoped_guard'
429 | __scoped_guard(_name, __UNIQUE_ID(label), args)
| ^~~~~~~~~~~~~~
drivers/tty/serial/8250/8250_port.c:2572:2: note: in expansion of macro 'scoped_guard'
2572 | scoped_guard(tty_port_tty, tport) {
| ^~~~~~~~~~~~
>> include/linux/cleanup.h:420:2: error: declaration of non-variable 'class_tty_port_tty_constructor' in 'for' loop initial declaration
420 | for (CLASS(_name, scope)(args); \
| ^~~
include/linux/cleanup.h:429:2: note: in expansion of macro '__scoped_guard'
429 | __scoped_guard(_name, __UNIQUE_ID(label), args)
| ^~~~~~~~~~~~~~
drivers/tty/serial/8250/8250_port.c:2572:2: note: in expansion of macro 'scoped_guard'
2572 | scoped_guard(tty_port_tty, tport) {
| ^~~~~~~~~~~~
>> include/linux/cleanup.h:403:28: error: implicit declaration of function 'class_tty_port_tty_lock_ptr'; did you mean 'class_uart_port_lock_lock_ptr'? [-Werror=implicit-function-declaration]
403 | #define __guard_ptr(_name) class_##_name##_lock_ptr
| ^~~~~~
include/linux/cleanup.h:421:7: note: in expansion of macro '__guard_ptr'
421 | __guard_ptr(_name)(&scope) || !__is_cond_ptr(_name); \
| ^~~~~~~~~~~
include/linux/cleanup.h:429:2: note: in expansion of macro '__scoped_guard'
429 | __scoped_guard(_name, __UNIQUE_ID(label), args)
| ^~~~~~~~~~~~~~
drivers/tty/serial/8250/8250_port.c:2572:2: note: in expansion of macro 'scoped_guard'
2572 | scoped_guard(tty_port_tty, tport) {
| ^~~~~~~~~~~~
>> include/linux/cleanup.h:405:30: error: 'class_tty_port_tty_is_conditional' undeclared (first use in this function); did you mean 'class_uart_port_lock_is_conditional'?
405 | #define __is_cond_ptr(_name) class_##_name##_is_conditional
| ^~~~~~
include/linux/cleanup.h:421:38: note: in expansion of macro '__is_cond_ptr'
421 | __guard_ptr(_name)(&scope) || !__is_cond_ptr(_name); \
| ^~~~~~~~~~~~~
include/linux/cleanup.h:429:2: note: in expansion of macro '__scoped_guard'
429 | __scoped_guard(_name, __UNIQUE_ID(label), args)
| ^~~~~~~~~~~~~~
drivers/tty/serial/8250/8250_port.c:2572:2: note: in expansion of macro 'scoped_guard'
2572 | scoped_guard(tty_port_tty, tport) {
| ^~~~~~~~~~~~
include/linux/cleanup.h:405:30: note: each undeclared identifier is reported only once for each function it appears in
405 | #define __is_cond_ptr(_name) class_##_name##_is_conditional
| ^~~~~~
include/linux/cleanup.h:421:38: note: in expansion of macro '__is_cond_ptr'
421 | __guard_ptr(_name)(&scope) || !__is_cond_ptr(_name); \
| ^~~~~~~~~~~~~
include/linux/cleanup.h:429:2: note: in expansion of macro '__scoped_guard'
429 | __scoped_guard(_name, __UNIQUE_ID(label), args)
| ^~~~~~~~~~~~~~
drivers/tty/serial/8250/8250_port.c:2572:2: note: in expansion of macro 'scoped_guard'
2572 | scoped_guard(tty_port_tty, tport) {
| ^~~~~~~~~~~~
>> drivers/tty/serial/8250/8250_port.c:2573:28: error: implicit declaration of function 'scoped_tty'; did you mean 'stop_tty'? [-Werror=implicit-function-declaration]
2573 | struct tty_struct *tty = scoped_tty();
| ^~~~~~~~~~
| stop_tty
drivers/tty/serial/8250/8250_port.c:2573:28: warning: initialization of 'struct tty_struct *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
cc1: some warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SERIAL_8250
Depends on [n]: TTY [=n] && HAS_IOMEM [=y] && !S390
Selected by [y]:
- ECONET [=y]
WARNING: unmet direct dependencies detected for SERIAL_OF_PLATFORM
Depends on [n]: TTY [=n] && HAS_IOMEM [=y] && SERIAL_8250 [=y] && OF [=y]
Selected by [y]:
- ECONET [=y]
vim +2572 drivers/tty/serial/8250/8250_port.c
2562
2563 /*
2564 * Note in order to avoid the tty port mutex deadlock don't use the next method
2565 * within the uart port callbacks. Primarily it's supposed to be utilized to
2566 * handle a sudden reference clock rate change.
2567 */
2568 void serial8250_update_uartclk(struct uart_port *port, unsigned int uartclk)
2569 {
2570 struct tty_port *tport = &port->state->port;
2571
> 2572 scoped_guard(tty_port_tty, tport) {
> 2573 struct tty_struct *tty = scoped_tty();
2574
2575 guard(rwsem_write)(&tty->termios_rwsem);
2576 guard(mutex)(&tport->mutex);
2577
2578 if (port->uartclk == uartclk)
2579 return;
2580
2581 port->uartclk = uartclk;
2582
2583 if (!tty_port_initialized(tport))
2584 return;
2585
2586 serial8250_do_set_termios(port, &tty->termios, NULL);
2587
2588 return;
2589 }
2590 guard(mutex)(&tport->mutex);
2591 port->uartclk = uartclk;
2592 }
2593 EXPORT_SYMBOL_GPL(serial8250_update_uartclk);
2594
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists