linux-kernel - Re: [PATCH v2] genirq/chip: Change irq_chip_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87secfsrzl.ffs@tglx>
Date: Thu, 08 Jan 2026 22:40:30 +0100
From: Thomas Gleixner <tglx@...nel.org>
To: "Rafael J. Wysocki" <rafael@...nel.org>, Linux PM
 <linux-pm@...r.kernel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Frederic Weisbecker
 <frederic@...nel.org>, Molnar Ingo <mingo@...nel.org>, Marc Zyngier
 <maz@...nel.org>, Lukas Wunner <lukas@...ner.de>, Sebastian Andrzej
 Siewior <bigeasy@...utronix.de>, Jon Hunter <jonathanh@...dia.com>, Ulf
 Hansson <ulf.hansson@...aro.org>, Brian Norris <briannorris@...omium.org>
Subject: Re: [PATCH v2] genirq/chip: Change irq_chip_pm_put() return type to
 void

On Thu, Jan 08 2026 at 16:05, Rafael J. Wysocki wrote:

> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> The irq_chip_pm_put() return value is only used in __irq_do_set_handler()
> to trigger a WARN_ON() if it is negative, but doing so is not useful
> because irq_chip_pm_put() simply passes the pm_runtime_put() return value
> to its callers.
>
> Returning an error code from pm_runtime_put() merely means that it has
> not queued up a work item to check whether or not the device can be
> suspended and there are many perfectly valid situations in which that
> can happen, like after writing "on" to the devices' runtime PM "control"
> attribute in sysfs for one example.
>
> For this reason, modify irq_chip_pm_put() to discard the pm_runtime_put()
> return value, change its return type to void, and drop the WARN_ON()
> around the irq_chip_pm_put() invocation from __irq_do_set_handler().
> Also update the irq_chip_pm_put() kerneldoc comment to be more accurate.
>
> This will facilitate a planned change of the pm_runtime_put() return
> type to void in the future.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>
> This patch is requisite for converting pm_runtime_put() into a void
> function.
>
> If you decide to pick it up, please let me know.
>
> Otherwise, an ACK or equivalent will be appreciated, but also the lack
> of specific criticism will be eventually regarded as consent.
>
> The v1 is here:
>
> https://lore.kernel.org/linux-pm/4723896.LvFx2qVVIh@rafael.j.wysocki/
>
> v1 -> v2:
>    * Fix a typo in the new part of the irq_chip_pm_put() kerneldoc comment
>      and rephrase it slightly.

Still:

Reviewed-by: Thomas Gleixner <tglx@...nel.org>