linux-kernel - Re: [PATCH] binder: don't use %pK through printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWAli6lnFT1tZQ4U@google.com>
Date: Thu, 8 Jan 2026 21:45:47 +0000
From: Carlos Llamas <cmllamas@...gle.com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arve Hjønnevåg <arve@...roid.com>,
	Todd Kjos <tkjos@...roid.com>,
	Christian Brauner <brauner@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] binder: don't use %pK through printk

On Wed, Jan 07, 2026 at 03:29:50PM +0100, Thomas Weißschuh wrote:
> In the past %pK was preferable to %p as it would not leak raw pointer
> values into the kernel log. Since commit ad67b74d2469 ("printk: hash
> addresses printed with %p") the regular %p has been improved to avoid
> this issue. Furthermore, restricted pointers ("%pK") were never meant
> to be used through printk(). They can still unintentionally leak raw
> pointers or acquire sleeping locks in atomic contexts.
> 
> Switch to the regular pointer formatting which is safer and
> easier to reason about.
> 
> There are still a few users of %pK left, but these use it through
> seq_file, for which its usage is safe.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> ---
Thanks Thomas,

Acked-by: Carlos Llamas <cmllamas@...gle.com>