| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202601090005.f0WEJEKH-lkp@intel.com>
Date: Fri, 9 Jan 2026 00:06:25 +0100
From: kernel test robot <lkp@...el.com>
To: Gregory CLEMENT <gregory.clement@...tlin.com>,
Rob Herring <robh@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Richard Weinberger <richard@....at>,
Vignesh Raghavendra <vigneshr@...com>,
Krzysztof Kozlowski <krzk@...nel.org>,
Conor Dooley <conor+dt@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>,
Benoît Monin <benoit.monin@...tlin.com>,
Théo Lebrun <theo.lebrun@...tlin.com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-mtd@...ts.infradead.org,
Gregory CLEMENT <gregory.clement@...tlin.com>
Subject: Re: [PATCH v3 2/4] of: reserved_mem: Support multiple 'reg' entries
for memory-region
Hi Gregory,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 8f0b4cce4481fb22653697cced8d0d04027cb1e8]
url: https://github.com/intel-lab-lkp/linux/commits/Gregory-CLEMENT/of-reserved_mem-Fix-placement-of-__free-annotation/20260107-211455
base: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
patch link: https://lore.kernel.org/r/20260107-mtd-memregion-v3-2-f9fc9107b992%40bootlin.com
patch subject: [PATCH v3 2/4] of: reserved_mem: Support multiple 'reg' entries for memory-region
config: arm64-allnoconfig-bpf (https://download.01.org/0day-ci/archive/20260109/202601090005.f0WEJEKH-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project f43d6834093b19baf79beda8c0337ab020ac5f17)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260109/202601090005.f0WEJEKH-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601090005.f0WEJEKH-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/of/of_reserved_mem.c:317:7: warning: variable 'err' is uninitialized when used here [-Wuninitialized]
317 | if (err == -ENOENT && of_get_flat_dt_prop(child, "size", NULL)) {
| ^~~
drivers/of/of_reserved_mem.c:300:10: note: initialize the variable 'err' to silence this warning
300 | int err, ret;
| ^
| = 0
1 warning generated.
vim +/err +317 drivers/of/of_reserved_mem.c
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 278
54c180e73ffa3e Rob Herring 2024-03-11 279 /*
54c180e73ffa3e Rob Herring 2024-03-11 280 * fdt_scan_reserved_mem() - scan a single FDT node for reserved memory
54c180e73ffa3e Rob Herring 2024-03-11 281 */
54c180e73ffa3e Rob Herring 2024-03-11 282 int __init fdt_scan_reserved_mem(void)
54c180e73ffa3e Rob Herring 2024-03-11 283 {
54c180e73ffa3e Rob Herring 2024-03-11 284 int node, child;
00c9a452a235c6 Oreoluwa Babatunde 2024-10-08 285 int dynamic_nodes_cnt = 0, count = 0;
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 286 int dynamic_nodes[MAX_RESERVED_REGIONS];
54c180e73ffa3e Rob Herring 2024-03-11 287 const void *fdt = initial_boot_params;
54c180e73ffa3e Rob Herring 2024-03-11 288
54c180e73ffa3e Rob Herring 2024-03-11 289 node = fdt_path_offset(fdt, "/reserved-memory");
54c180e73ffa3e Rob Herring 2024-03-11 290 if (node < 0)
54c180e73ffa3e Rob Herring 2024-03-11 291 return -ENODEV;
54c180e73ffa3e Rob Herring 2024-03-11 292
54c180e73ffa3e Rob Herring 2024-03-11 293 if (__reserved_mem_check_root(node) != 0) {
54c180e73ffa3e Rob Herring 2024-03-11 294 pr_err("Reserved memory: unsupported node format, ignoring\n");
54c180e73ffa3e Rob Herring 2024-03-11 295 return -EINVAL;
54c180e73ffa3e Rob Herring 2024-03-11 296 }
54c180e73ffa3e Rob Herring 2024-03-11 297
54c180e73ffa3e Rob Herring 2024-03-11 298 fdt_for_each_subnode(child, fdt, node) {
54c180e73ffa3e Rob Herring 2024-03-11 299 const char *uname;
8be14ac8dccc70 Gregory CLEMENT 2026-01-07 300 int err, ret;
54c180e73ffa3e Rob Herring 2024-03-11 301
54c180e73ffa3e Rob Herring 2024-03-11 302 if (!of_fdt_device_is_available(fdt, child))
54c180e73ffa3e Rob Herring 2024-03-11 303 continue;
54c180e73ffa3e Rob Herring 2024-03-11 304
54c180e73ffa3e Rob Herring 2024-03-11 305 uname = fdt_get_name(fdt, child, NULL);
54c180e73ffa3e Rob Herring 2024-03-11 306
8be14ac8dccc70 Gregory CLEMENT 2026-01-07 307 ret = __reserved_mem_reserve_reg(child, uname);
8be14ac8dccc70 Gregory CLEMENT 2026-01-07 308 if (ret > 0)
8be14ac8dccc70 Gregory CLEMENT 2026-01-07 309 count += ret;
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 310 /*
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 311 * Save the nodes for the dynamically-placed regions
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 312 * into an array which will be used for allocation right
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 313 * after all the statically-placed regions are reserved
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 314 * or marked as no-map. This is done to avoid dynamically
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 315 * allocating from one of the statically-placed regions.
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 316 */
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 @317 if (err == -ENOENT && of_get_flat_dt_prop(child, "size", NULL)) {
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 318 dynamic_nodes[dynamic_nodes_cnt] = child;
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 319 dynamic_nodes_cnt++;
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 320 }
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 321 }
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 322 for (int i = 0; i < dynamic_nodes_cnt; i++) {
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 323 const char *uname;
00c9a452a235c6 Oreoluwa Babatunde 2024-10-08 324 int err;
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 325
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 326 child = dynamic_nodes[i];
8a6e02d0c00e7b Oreoluwa Babatunde 2024-10-08 327 uname = fdt_get_name(fdt, child, NULL);
00c9a452a235c6 Oreoluwa Babatunde 2024-10-08 328 err = __reserved_mem_alloc_size(child, uname);
00c9a452a235c6 Oreoluwa Babatunde 2024-10-08 329 if (!err)
00c9a452a235c6 Oreoluwa Babatunde 2024-10-08 330 count++;
54c180e73ffa3e Rob Herring 2024-03-11 331 }
00c9a452a235c6 Oreoluwa Babatunde 2024-10-08 332 total_reserved_mem_cnt = count;
54c180e73ffa3e Rob Herring 2024-03-11 333 return 0;
54c180e73ffa3e Rob Herring 2024-03-11 334 }
54c180e73ffa3e Rob Herring 2024-03-11 335
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists