linux-kernel - Re: [PATCH] perf inject: Keep build-ID data if no option is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWBEaNVsoizw4Aax@google.com>
Date: Thu, 8 Jan 2026 15:57:28 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Ian Rogers <irogers@...gle.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: James Clark <james.clark@...aro.org>, Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	linux-perf-users@...r.kernel.org, Gabriel Marin <gmx@...gle.com>
Subject: Re: [PATCH] perf inject: Keep build-ID data if no option is used

Hi Ian,

On Wed, Dec 17, 2025 at 10:57:01AM -0800, Ian Rogers wrote:
> On Wed, Dec 17, 2025 at 10:39 AM Namhyung Kim <namhyung@...nel.org> wrote:
> >
> > The keep_feat() determines which header features will be kept or
> > discarded.  Usually perf inject will add build-IDs based on -b, -B or
> > other related options.  But it lose build-ID when none of those options
> > are used.  This is meaningful only when --buildid-mmap is not used.
> >
> > The following example shows the impact of this change.
> >
> >   $ perf record --no-buildid-mmap true
> >   [ perf record: Woken up 1 times to write data ]
> >   [ perf record: Captured and wrote 0.037 MB perf.data (5 samples) ]
> >
> >   $ perf inject -i perf.data -o perf.data.inject
> >
> >   $ perf buildid-list -i perf.data
> >   08cccc2a9388d5247ccb3e864f3063b975b0a15d /usr/lib/x86_64-linux-gnu/ld-linux-x86-64.so.2
> >   fd5c4d5673256cd6bda51725dba048dabb0f854e [kernel.kallsyms]
> >   97a36ce1140071be5c36b147fa0bed173e05a602 [vdso]
> >
> >   $ perf buildid-list -i perf.data.inject
> >   97a36ce1140071be5c36b147fa0bed173e05a602 [vdso]
> >
> > With this change, perf.data.inject would show the same list (of course,
> > you need to run perf inject again).
> >
> > Reported-by: Gabriel Marin <gmx@...gle.com>
> > Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> 
> Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks for the review!

Arnaldo, any chance you can pick this up soon?

Thanks,
Namhyung