linux-kernel - [PATCH] media: i2c: os05b10: Few minor improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20260108055454.71358-1-himanshu.bhavani@siliconsignals.io>
Date: Thu,  8 Jan 2026 11:24:54 +0530
From: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
To: sakari.ailus@...ux.intel.com
Cc: himanshu.bhavani@...iconsignals.io,
	benjamin.mugnier@...s.st.com,
	clamor95@...il.com,
	conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	dongcheng.yan@...el.com,
	elgin.perumbilly@...iconsignals.io,
	git@...tzsch.eu,
	hansg@...nel.org,
	hardevsinh.palaniya@...iconsignals.io,
	heimir.sverrisson@...il.com,
	hverkuil@...nel.org,
	krzk+dt@...nel.org,
	laurent.pinchart@...asonboard.com,
	linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org,
	mchehab@...nel.org,
	mehdi.djait@...ux.intel.com,
	robh@...nel.org,
	sylvain.petinot@...s.st.com,
	vladimir.zapolskiy@...aro.org
Subject: [PATCH] media: i2c: os05b10: Few minor improvements

Signed-off-by: Himanshu Bhavani <himanshu.bhavani@...iconsignals.io>
---
 drivers/media/i2c/os05b10.c | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c
index 5a457f01fe47..f1b03584b40b 100644
--- a/drivers/media/i2c/os05b10.c
+++ b/drivers/media/i2c/os05b10.c
@@ -708,7 +708,7 @@ static int os05b10_disable_streams(struct v4l2_subdev *sd,

 	pm_runtime_put(os05b10->dev);

-	return ret;
+	return 0;
 }

 static int os05b10_init_state(struct v4l2_subdev *sd,
@@ -884,17 +884,13 @@ static u64 os05b10_pixel_rate(struct os05b10 *os05b10,
 			      const struct os05b10_mode *mode)
 {
 	u64 link_freq = link_frequencies[os05b10->link_freq_index];
-	const unsigned int lanes = os05b10->data_lanes;
-	u64 numerator = link_freq * 2 * lanes;
-	unsigned int bpp = mode->bpp;
-
-	do_div(numerator, bpp);
+	u64 pixel_rate = div_u64(link_freq * 2 * os05b10->data_lanes, mode->bpp);

-	dev_info(os05b10->dev,
-		 "link_freq=%llu bpp=%u lanes=%u pixel_rate=%llu\n",
-		 link_freq, bpp, lanes, numerator);
+	dev_dbg(os05b10->dev,
+		"link_freq=%llu bpp=%u lanes=%u pixel_rate=%llu\n",
+		link_freq, mode->bpp, os05b10->data_lanes, pixel_rate);

-	return numerator;
+	return pixel_rate;
 }

 static int os05b10_init_controls(struct os05b10 *os05b10)
@@ -977,7 +973,6 @@ static int os05b10_probe(struct i2c_client *client)
 {
 	struct os05b10 *os05b10;
 	unsigned int xclk_freq;
-	unsigned int i;
 	int ret;

 	os05b10 = devm_kzalloc(&client->dev, sizeof(*os05b10), GFP_KERNEL);
@@ -1005,7 +1000,7 @@ static int os05b10_probe(struct i2c_client *client)
 				     "xclk frequency not supported: %d Hz\n",
 				     xclk_freq);

-	for (i = 0; i < ARRAY_SIZE(os05b10_supply_name); i++)
+	for (unsigned int i = 0; i < ARRAY_SIZE(os05b10_supply_name); i++)
 		os05b10->supplies[i].supply = os05b10_supply_name[i];

 	ret = devm_regulator_bulk_get(os05b10->dev,
--
2.34.1