linux-kernel - Re: [PATCH] iio: adc: ad7476: Remove duplicate include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd506e0f-9e52-498d-8e35-077ab52efbd7@gmail.com>
Date: Thu, 8 Jan 2026 08:06:13 +0200
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Chen Ni <nichen@...as.ac.cn>, lars@...afoo.de,
 Michael.Hennerich@...log.com, jic23@...nel.org, dlechner@...libre.com,
 nuno.sa@...log.com, andy@...nel.org
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ad7476: Remove duplicate include

On 07/01/2026 10:29, Chen Ni wrote:
> Remove duplicate inclusion of linux/bitops.h.
> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>

I would also appreciate having the includes alphabetically ordered as 
Andy suggested. This, however, is a fine fix as it is so:

Reviewed-by: Matti Vaittinen <mazziesaccount@...il.com>

> ---
>   drivers/iio/adc/ad7476.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7476.c b/drivers/iio/adc/ad7476.c
> index 1bec6657394c..21d3f6aae972 100644
> --- a/drivers/iio/adc/ad7476.c
> +++ b/drivers/iio/adc/ad7476.c
> @@ -16,7 +16,6 @@
>   #include <linux/gpio/consumer.h>
>   #include <linux/err.h>
>   #include <linux/module.h>
> -#include <linux/bitops.h>
>   #include <linux/delay.h>
>   
>   #include <linux/iio/iio.h>


-- 
---
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~