linux-kernel - Re: [PATCH v2 2/2] arm64: dts: rockchip: Add rk3576 evb2 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABjd4YzsjZXe16XWgrHRG5shNA_DQJF45i1roahvfAfV4xdU0Q@mail.gmail.com>
Date: Thu, 8 Jan 2026 10:53:17 +0400
From: Alexey Charkov <alchark@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Chaoyi Chen <kernel@...kyi.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Heiko Stuebner <heiko@...ech.de>, Quentin Schulz <quentin.schulz@...rry.de>, 
	Chaoyi Chen <chaoyi.chen@...k-chips.com>, Kever Yang <kever.yang@...k-chips.com>, 
	Jonas Karlman <jonas@...boo.se>, John Clark <inindev@...il.com>, FUKAUMI Naoki <naoki@...xa.com>, 
	Jimmy Hon <honyuenkwun@...il.com>, Dragan Simic <dsimic@...jaro.org>, 
	Michael Riesch <michael.riesch@...labora.com>, Peter Robinson <pbrobinson@...il.com>, 
	Shawn Lin <shawn.lin@...k-chips.com>, 
	Sebastian Reichel <sebastian.reichel@...labora.com>, Andy Yan <andy.yan@...k-chips.com>, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add rk3576 evb2 board

On Wed, Jan 7, 2026 at 10:18 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> > +&gmac0 {
> > +     clock_in_out = "output";
> > +     phy-mode = "rgmii-rxid";
>
> rgmii-rxid is odd. Does the PCB really have an extra long TX clock
> line, but a short RX clock line?
>
> Try changing this to rgmii-id, and drop the tx_delay property.

Actually it would be great if Rockchip could clarify the delay
duration introduced by a single delay element in GMAC-IOMUX delay
lines, which are controlled in the GMAC driver by the {tx,rx}_delay
properties. Maybe we could then switch to using
{tx,rx}_internal_delay_ps for fine-tuning the delays on the GMAC side
as envisaged in DT bindings [1], and use phy-mode = "rgmii-id"
throughout. Chaoyi, any chance you could ask around in your hardware
team?

Currently though removing the delays at GMAC side altogether causes
unstable link operation - see [2] for example.

[1] https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/net/ethernet-controller.yaml#L342-L347
[2] https://gitlab.collabora.com/hardware-enablement/rockchip-3588/linux/-/commit/372f3e9ae62cc62cdf2543391ea57be6bb548a0c

Best regards,
Alexey