linux-kernel - Re: [PATCH v3 07/11] dt-bindings: clock: qcom: document the Kaanapali GPU Clock Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260108-eminent-rich-mink-6acaf7@quoll>
Date: Thu, 8 Jan 2026 09:17:49 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Taniya Das <taniya.das@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Maxime Coquelin <mcoquelin.stm32@...il.com>, 
	Alexandre Torgue <alexandre.torgue@...s.st.com>, Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>, 
	Jagadeesh Kona <quic_jkona@...cinc.com>, Konrad Dybcio <konradybcio@...nel.org>, 
	Ajit Pandey <ajit.pandey@....qualcomm.com>, Imran Shaik <imran.shaik@....qualcomm.com>, 
	Jagadeesh Kona <jagadeesh.kona@....qualcomm.com>, linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org, 
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, 
	Jingyi Wang <jingyi.wang@....qualcomm.com>, Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Subject: Re: [PATCH v3 07/11] dt-bindings: clock: qcom: document the
 Kaanapali GPU Clock Controller

On Wed, Jan 07, 2026 at 03:13:10PM +0530, Taniya Das wrote:
> Qualcomm GX(graphics) is a clock controller which has PLLs, clocks and
> Power domains (GDSC), but the requirement from the SW driver is to use

Requirement of what? or of whom? DXCTL requires to use GDSC?

In any case your driver requirements should not really shape new
bindings. I already said this last time.

> the GDSC power domain from the clock controller to recover the GPU
> firmware in case of any failure/hangs. The rest of the resources of the
> clock controller are being used by the firmware of GPU. This module
> exposes the GDSC power domains which helps the recovery of Graphics
> subsystem.
> 
> Add bindings documentation for the Kaanapali Graphics Clock and Graphics
> power domain Controller for Kaanapali SoC.
> 
> Signed-off-by: Jingyi Wang <jingyi.wang@....qualcomm.com>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> Signed-off-by: Taniya Das <taniya.das@....qualcomm.com>
> ---
>  .../bindings/clock/qcom,kaanapali-gxclkctl.yaml    | 63 ++++++++++++++++++++++
>  .../bindings/clock/qcom,sm8450-gpucc.yaml          |  2 +
>  include/dt-bindings/clock/qcom,kaanapali-gpucc.h   | 47 ++++++++++++++++
>  .../dt-bindings/clock/qcom,kaanapali-gxclkctl.h    | 13 +++++
>  4 files changed, 125 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,kaanapali-gxclkctl.yaml b/Documentation/devicetree/bindings/clock/qcom,kaanapali-gxclkctl.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..5490a975f3db7d253a17cc13a67f6c44e0d47ef3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,kaanapali-gxclkctl.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,kaanapali-gxclkctl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Graphics power domain Controller on Kaanapali
> +
> +maintainers:
> +  - Taniya Das <taniya.das@....qualcomm.com>
> +
> +description: |
> +  Qualcomm GX(graphics) is a clock controller which has PLLs, clocks and
> +  Power domains (GDSC). This module provides the power domains control
> +  of gxclkctl on Qualcomm SoCs which helps the recovery of Graphics subsystem.
> +
> +  See also:
> +    include/dt-bindings/clock/qcom,kaanapali-gxclkctl.h
> +
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,kaanapali-gxclkctl
> +
> +  power-domains:
> +    description:
> +      Power domains required for the clock controller to operate
> +    items:
> +      - description: GFX power domain
> +      - description: GMXC power domain
> +      - description: GPUCC(CX) power domain
> +
> +  '#power-domain-cells':
> +    const: 1
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - power-domains
> +  - '#power-domain-cells'
> +
> +unevaluatedProperties: false

additionalProperties instead.

Best regards,
Krzysztof