linux-kernel - Re: [PATCH 01/15] reset: gpio: remove unneeded OF-node put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc30556dc3f47b317d914142ff1a8afd4e4a0419.camel@pengutronix.de>
Date: Thu, 08 Jan 2026 10:02:37 +0100
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>, Krzysztof
 Kozlowski <krzk@...nel.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/15] reset: gpio: remove unneeded OF-node put

On Mo, 2026-01-05 at 15:15 +0100, Bartosz Golaszewski wrote:
> Tasking the reset-gpio driver with controlling the reference count of an
> OF node set up in reset core is a weird inversion of responsability.

priv->rc.of_node isn't set anywhere.
The device node set and used by the core is priv->rc.of_args->np.
Could you change the commit message to reflect this?
Otherwise,

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

for the patch content. 


regards
Philipp