linux-kernel - Re: [PATCH] gpio: drop Kconfig dependencies from symbol GPIO_TN48M

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Mcows9Mq9UC+307HzdV06zqRLgB9Bz=7igamT8k0mTCEA@mail.gmail.com>
Date: Thu, 8 Jan 2026 10:04:00 +0100
From: Bartosz Golaszewski <brgl@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, Robert Marko <robert.marko@...tura.hr>, 
	Linus Walleij <linusw@...nel.org>, linux-gpio@...r.kernel.org, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] gpio: drop Kconfig dependencies from symbol GPIO_TN48M_CPLD

On Thu, Jan 8, 2026 at 4:42 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> MFD_TN48M_CPLD is an undefined Kconfig symbol, so remove its use
> in drivers/gpio/Kconfig.
> Drop COMPILE_TEST so that the driver can be built at any time.
>
> Fixes: b3dcb5de6209 ("gpio: Add Delta TN48M CPLD GPIO driver")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> ---
> Cc: Robert Marko <robert.marko@...tura.hr>
> Cc: Linus Walleij <linusw@...nel.org>
> Cc: Bartosz Golaszewski <brgl@...nel.org>
> Cc: linux-gpio@...r.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>
>  drivers/gpio/Kconfig |    1 -
>  1 file changed, 1 deletion(-)
>
> --- linux-next-20260105.orig/drivers/gpio/Kconfig
> +++ linux-next-20260105/drivers/gpio/Kconfig
> @@ -1621,7 +1621,6 @@ config GPIO_TIMBERDALE
>
>  config GPIO_TN48M_CPLD
>         tristate "Delta Networks TN48M switch CPLD GPIO driver"
> -       depends on MFD_TN48M_CPLD || COMPILE_TEST
>         select GPIO_REGMAP
>         help
>           This enables support for the GPIOs found on the Delta

I see the core MFD part of this driver was reverted by commit
540e6a8114d0 ("Revert "mfd: simple-mfd-i2c: Add Delta TN48M CPLD
support"") years ago. Should this driver even be in the kernel? It
seems to be useless without the parent driver that supplies the
regmap?

I'm asking, because with your change, it will pop up in people's make
config and I've been yelled at before for displaying useless options
so I'm hesitant to make it visible for everyone.

Bart