[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <909110018686854d129ec579cd3852d29ab60be6.camel@codeconstruct.com.au>
Date: Thu, 08 Jan 2026 19:28:24 +1030
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: openbmc@...ts.ozlabs.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Avi Fishman <avifishman70@...il.com>, Tomer
Maimon <tmaimon77@...il.com>, Tali Perry <tali.perry1@...il.com>, Patrick
Venture <venture@...gle.com>, Nancy Yuen <yuenn@...gle.com>, Benjamin Fair
<benjaminfair@...gle.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH] arm64: dts: nuvoton: Add missing "device_type" property
on memory node
On Thu, 2026-01-08 at 17:39 +1030, Andrew Jeffery wrote:
> On Mon, 2026-01-05 at 13:32 -0600, Rob Herring (Arm) wrote:
> > "device_type" is required for memory nodes, but is missing on Nuvoton
> > npcm845-evb.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> > ---
> > arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts b/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts
> > index 2638ee1c3846..5edf5d13342d 100644
> > --- a/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts
> > +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts
> > @@ -17,6 +17,7 @@ chosen {
> > };
> >
> > memory@0 {
> > + device_type = "memory";
> > reg = <0x0 0x0 0x0 0x40000000>;
> > };
> >
>
> Hmm, we have quite a few other offenders under arch/arm/boot/dts/aspeed
> too. I expect this should be caught by CHECK_DTBS=y?
>
> Digging back through my build archives, warnings have cropped up, but
> only for when I'm building the arm64 or arm multi_v{5,7} defconfigsm
> and seemingly not the aspeed_g5 defconfig.
Ah the aspeed dtsis define a memory node with it and some zero-length
memory, and the node properties are updated by the dts files.
False alarm.
Andrew
Powered by blists - more mailing lists