linux-kernel - Re: [PATCH 2/2] gpu: nova-core: don't print raw PMU table entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6342AE4E-DB30-4367-8C3A-53EDD02C3D19@nvidia.com>
Date: Thu, 8 Jan 2026 01:52:36 +0000
From: Joel Fernandes <joelagnelf@...dia.com>
To: John Hubbard <jhubbard@...dia.com>
CC: Danilo Krummrich <dakr@...nel.org>, Alexandre Courbot
	<acourbot@...dia.com>, Timur Tabi <ttabi@...dia.com>, Alistair Popple
	<apopple@...dia.com>, Edwin Peer <epeer@...dia.com>, Zhi Wang
	<zhiw@...dia.com>, David Airlie <airlied@...il.com>, Simona Vetter
	<simona@...ll.ch>, Bjorn Helgaas <bhelgaas@...gle.com>, Miguel Ojeda
	<ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng
	<boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin
	<lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl
	<aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	"nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
	"rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>, LKML
	<linux-kernel@...r.kernel.org>, John Hubbard <jhubbard@...dia.com>
Subject: Re: [PATCH 2/2] gpu: nova-core: don't print raw PMU table entries



> On Jan 7, 2026, at 7:58 PM, John Hubbard <jhubbard@...dia.com> wrote:
> 
> Remove the (large) raw form of the PMU table entries. The resulting
> PMULookupTable is still getting printed (in more useful form) later,
> anyway, so this was redundant, even for debugging. This output (the
> example is from an Ampere GPU) is what is being removed:
> 
> NovaCore 0000:e1:00.0: PMU entry: [01, 01, 54, 54, 01, 00]
> NovaCore 0000:e1:00.0: PMU entry: [00, 00, 00, 00, 00, 00]
> NovaCore 0000:e1:00.0: PMU entry: [00, 00, 00, 00, 00, 00]
> NovaCore 0000:e1:00.0: PMU entry: [00, 00, 00, 00, 00, 00]
> NovaCore 0000:e1:00.0: PMU entry: [00, 00, 00, 00, 00, 00]
> NovaCore 0000:e1:00.0: PMU entry: [07, 06, e0, b7, 03, 00]
> NovaCore 0000:e1:00.0: PMU entry: [08, 01, bc, 56, 05, 00]
> NovaCore 0000:e1:00.0: PMU entry: [00, 00, 00, 00, 00, 00]
> NovaCore 0000:e1:00.0: PMU entry: [45, 07, 88, da, 01, 00]
> NovaCore 0000:e1:00.0: PMU entry: [85, 07, 34, c9, 02, 00]
> NovaCore 0000:e1:00.0: PMU entry: [49, 05, 7c, b3, 04, 00]
> NovaCore 0000:e1:00.0: PMU entry: [89, 05, 1c, 05, 05, 00]
> NovaCore 0000:e1:00.0: PMU entry: [00, 00, 00, 00, 00, 00]
> NovaCore 0000:e1:00.0: PMU entry: [00, 00, 00, 00, 00, 00]
> NovaCore 0000:e1:00.0: PMU entry: [00, 00, 00, 00, 00, 00]
> NovaCore 0000:e1:00.0: PMU entry: [00, 00, 00, 00, 00, 00]
> 
> And it is immediately followed by a more useful, interpreted list of
> selected PMU table data, which is *not* being removed as part of this
> commit. That looks like this:
> 
> NovaCore 0000:e1:00.0: PmuLookupTableEntry desc: FalconUCodeDescV3 {
>    hdr: 78381825,
>    stored_size: 59904,
>    pkc_data_offset: 1444,
>    interface_offset: 28,
>    imem_phys_base: 0,
>    imem_load_size: 57856,
>    imem_virt_base: 0,
>    dmem_phys_base: 0,
>    dmem_load_size: 2048,
>    engine_id_mask: 1024,
>    ucode_id: 9,
>    signature_count: 3,
>    signature_versions: 7,
>    _reserved: 37449,
> }
> 
> Signed-off-by: John Hubbard <jhubbard@...dia.com>

Acked-by: Joel Fernandes <joelagnelf@...dia.com>

thanks,

 - Joel





> ---
> drivers/gpu/nova-core/vbios.rs | 5 -----
> 1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/nova-core/vbios.rs b/drivers/gpu/nova-core/vbios.rs
> index 7c26e4a2d61c..ac01eb195fb2 100644
> --- a/drivers/gpu/nova-core/vbios.rs
> +++ b/drivers/gpu/nova-core/vbios.rs
> @@ -887,11 +887,6 @@ fn new(dev: &device::Device, data: &[u8]) -> Result<Self> {
>             ret
>         };
> 
> -        // Debug logging of entries (dumps the table data to dmesg)
> -        for i in (header_len..required_bytes).step_by(entry_len) {
> -            dev_dbg!(dev, "PMU entry: {:02x?}\n", &data[i..][..entry_len]);
> -        }
> -
>         Ok(PmuLookupTable { header, table_data })
>     }
> 
> --
> 2.52.0
>