linux-kernel - Re: [PATCH] staging: fbtft: align tinylcd write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2026010823-floral-alphabet-4aef@gregkh>
Date: Thu, 8 Jan 2026 10:57:53 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Chaitanya Mishra <chaitanyamishra.ai@...il.com>
Cc: andy@...nel.org, dri-devel@...ts.freedesktop.org,
	linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: fbtft: align tinylcd write_reg args

On Thu, Jan 08, 2026 at 03:17:09PM +0530, Chaitanya Mishra wrote:
> Checkpatch reports a misaligned continuation line in the
> 
> fb_tinylcd init_display() write_reg() gamma table. Align the
> 
> continuation line with the open parenthesis to match kernel style.
> 
> No functional change.
> 
> Signed-off-by: Chaitanya Mishra <chaitanyamishra.ai@...il.com>
> ---
>  drivers/staging/fbtft/fb_tinylcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
> index 9469248f2c50..60cda57bcb33 100644
> --- a/drivers/staging/fbtft/fb_tinylcd.c
> +++ b/drivers/staging/fbtft/fb_tinylcd.c
> @@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
>  	write_reg(par, 0xE5, 0x00);
>  	write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
>  	write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
> -		       0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> +		  0x00, 0x35, 0x33, 0x00, 0x00, 0x00);

That kind of makes the code harder to read, right?

checkpatch is a guide, always use it as a hint, not as a rule.

thanks,

greg k-h