linux-kernel - Re: [PATCH v7 3/4] clk: samsung: Implement automatic clock gating mode for CMUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c09a8c461db5a09e75de4587eef38bffbccf2d2.camel@linaro.org>
Date: Thu, 08 Jan 2026 10:55:45 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Marek Szyprowski <m.szyprowski@...sung.com>, Peter Griffin	
 <peter.griffin@...aro.org>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski	 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Alim
 Akhtar	 <alim.akhtar@...sung.com>, Tudor Ambarus
 <tudor.ambarus@...aro.org>, Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Sam Protsenko	
 <semen.protsenko@...aro.org>, Sylwester Nawrocki <s.nawrocki@...sung.com>, 
 Chanwoo Choi <cw00.choi@...sung.com>
Cc: Will McVicker <willmcvicker@...gle.com>, Krzysztof Kozlowski	
 <krzk@...nel.org>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
 kernel-team@...roid.com
Subject: Re: [PATCH v7 3/4] clk: samsung: Implement automatic clock gating
 mode for CMUs

Hi Marek,

On Thu, 2026-01-08 at 00:59 +0100, Marek Szyprowski wrote:
> > @@ -334,10 +456,20 @@ void samsung_clk_extended_sleep_init(void __iomem *reg_base,
> >     * samsung_cmu_register_clocks() - Register all clocks provided in CMU object
> >     * @ctx: Clock provider object
> >     * @cmu: CMU object with clocks to register
> > + * @np:  CMU device tree node
> >     */
> >    void __init samsung_cmu_register_clocks(struct samsung_clk_provider *ctx,
> > -					const struct samsung_cmu_info *cmu)
> > +					const struct samsung_cmu_info *cmu,
> > +					struct device_node *np)
> >    {
> > +	if (samsung_is_auto_capable(np) && cmu->auto_clock_gate)
> > +		ctx->auto_clock_gate = cmu->auto_clock_gate;
> 
> Do we need to issue "incorrect res size for automatic clocks" warning 
> for every legacy Exynos based board? The check above should be in 
> reverse order:
> 
> if (cmu->auto_clock_gates && amsung_is_auto_capable(np))
> 	ctx->auto_clock_gate = cmu->auto_clock_gate;

Good suggestion. I have one or two cleanups anyway, I'll add that as well.

Thanks for spotting this!

Cheers,
Andre'