linux-kernel - Re: [PATCH v2] gpio: davinci: implement .get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DFK4BWTWHHQF.2IBES82YDKAEC@kernel.org>
Date: Fri, 09 Jan 2026 15:12:23 +0100
From: "Michael Walle" <mwalle@...nel.org>
To: "Bartosz Golaszewski" <bartosz.golaszewski@....qualcomm.com>, "Keerthy"
 <j-keerthy@...com>, "Linus Walleij" <linusw@...nel.org>, "Bartosz
 Golaszewski" <brgl@...nel.org>
Cc: <linux-kernel@...r.kernel.org>, <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v2] gpio: davinci: implement .get_direction()

Hi,

On Fri Jan 9, 2026 at 2:08 PM CET, Bartosz Golaszewski wrote:
> It's strongly recommended for GPIO drivers to always implement the
> .get_direction() callback - even for fixed-direction controllers.
>
> GPIO core will even emit a warning if the callback is missing, when
> users try to read the direction of a pin.
>
> Implement .get_direction() for gpio-davinci.

I must be blind! I didn't see the direction register and I assumed
that the direction is fixed and only known by the pinctrl (as on k3
SoCs, you have to hardcode the directions of GPIOs in the device
tree.

Thanks for taking care.

> Reported-by: Michael Walle <mwalle@...nel.org>
> Closes: https://lore.kernel.org/all/DFJAFK3DTBOZ.3G2P3A5IH34GF@kernel.org/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>

This will need a

Fixes: a060b8c511ab ("gpiolib: implement low-level, shared GPIO support")

Otherwise the sa67 board will be broken with the defconfig (or any
config enabled ARCH_QCOM).

Tested-by: Michael Walle <mwalle@...nel.org> # on sa67

-michael

Download attachment "signature.asc" of type "application/pgp-signature" (298 bytes)