linux-kernel - Re: [PATCH net-next v10 2/9] hinic3: Add PF management interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260109062342.2a6b1c89@kernel.org>
Date: Fri, 9 Jan 2026 06:23:42 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Fan Gong <gongfan1@...wei.com>
Cc: Zhu Yikai <zhuyikai1@...artners.com>, <netdev@...r.kernel.org>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Andrew Lunn
 <andrew+netdev@...n.ch>, Markus Elfring <Markus.Elfring@....de>, Pavan
 Chebbi <pavan.chebbi@...adcom.com>, ALOK TIWARI <alok.a.tiwari@...cle.com>,
 <linux-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>, luosifu
 <luosifu@...wei.com>, Xin Guo <guoxin09@...wei.com>, Zhou Shuai
 <zhoushuai28@...wei.com>, Wu Like <wulike1@...wei.com>, Shi Jing
 <shijing34@...wei.com>, Luo Yang <luoyang82@...artners.com>
Subject: Re: [PATCH net-next v10 2/9] hinic3: Add PF management interfaces

On Fri, 9 Jan 2026 10:35:52 +0800 Fan Gong wrote:
> +static void hinic3_init_mgmt_msg_work(struct hinic3_msg_pf_to_mgmt *pf_to_mgmt,
> +				      struct hinic3_recv_msg *recv_msg)
> +{
> +	struct mgmt_msg_handle_work *mgmt_work;
> +
> +	mgmt_work = kmalloc(sizeof(*mgmt_work), GFP_KERNEL);
> +	if (!mgmt_work)
> +		return;
> +
> +	if (recv_msg->msg_len) {
> +		mgmt_work->msg = kmalloc(recv_msg->msg_len, GFP_KERNEL);
> +		if (!mgmt_work->msg) {
> +			kfree(mgmt_work);
> +			return;
> +		}
> +		memcpy(mgmt_work->msg, recv_msg->msg, recv_msg->msg_len);

coccicheck says:

drivers/net/ethernet/huawei/hinic3/hinic3_mgmt.c:128:19-26: WARNING opportunity for kmemdup
-- 
pw-bot: cr