linux-kernel - Re: [PATCH v2] gpio: davinci: implement .get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD++jLmVxFq1Dc6T_aR4C3dpcY9cO32jjWj98G_z1U4i0mVqXA@mail.gmail.com>
Date: Fri, 9 Jan 2026 15:32:12 +0100
From: Linus Walleij <linusw@...nel.org>
To: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>
Cc: Keerthy <j-keerthy@...com>, Bartosz Golaszewski <brgl@...nel.org>, linux-kernel@...r.kernel.org, 
	linux-gpio@...r.kernel.org, Michael Walle <mwalle@...nel.org>
Subject: Re: [PATCH v2] gpio: davinci: implement .get_direction()

On Fri, Jan 9, 2026 at 2:08 PM Bartosz Golaszewski
<bartosz.golaszewski@....qualcomm.com> wrote:

> It's strongly recommended for GPIO drivers to always implement the
> .get_direction() callback - even for fixed-direction controllers.
>
> GPIO core will even emit a warning if the callback is missing, when
> users try to read the direction of a pin.
>
> Implement .get_direction() for gpio-davinci.
>
> Reported-by: Michael Walle <mwalle@...nel.org>
> Closes: https://lore.kernel.org/all/DFJAFK3DTBOZ.3G2P3A5IH34GF@kernel.org/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>

Reviewed-by: Linus Walleij <linusw@...nel.org>

Yours,
Linus Walleij