linux-kernel - Re: [PATCH 1/2] arm64: dts: renesas: Use hyphen in node names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e49ae45-87d6-469a-8cbf-6b43a1ea498f@oss.qualcomm.com>
Date: Fri, 9 Jan 2026 16:22:09 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Magnus Damm <magnus.damm@...il.com>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>, linux-renesas-soc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: renesas: Use hyphen in node names

On 09/01/2026 16:18, Geert Uytterhoeven wrote:
> Hi Krzysztof,
> 
> On Tue, 23 Dec 2025 at 16:24, Krzysztof Kozlowski
> <krzysztof.kozlowski@....qualcomm.com> wrote:
>> DTS coding style prefers hyphens instead of underscores in the node
>> names.  Change should be safe, because node names are not considered an
>> ABI.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
> 
> Thanks for your patch!
> 
>>  arch/arm64/boot/dts/renesas/r8a77970-eagle.dts   | 4 ++--
>>  arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts   | 4 ++--
>>  arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts   | 4 ++--
>>  arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ++--
>>  arch/arm64/boot/dts/renesas/ulcb.dtsi            | 2 +-
>>  5 files changed, 9 insertions(+), 9 deletions(-)
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> 
> Is there any specific reason you didn't fix the remaining ones?

These are coming from scripted sed, so probably my regex was incomplete.
But in few cases (not sure if here) I did not touch clock node names, if
they do not have clock-output-names, because it might break users.

> 
> $ git grep  -e  '[a-zA-Z0-9-]*_[a-zA-Z0-9-]*@' HEAD --
> arch/arm64/boot/dts/renesas
> arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi:
> versaclock5: versaclock_som@6a {
> arch/arm64/boot/dts/renesas/condor-common.dtsi:
> cert_header_sa3@...00 {
> arch/arm64/boot/dts/renesas/condor-common.dtsi:
> cert_header_sa6@...000 {
> arch/arm64/boot/dts/renesas/draak.dtsi:
> cert_header_sa6@...000 {
> arch/arm64/boot/dts/renesas/ebisu.dtsi:
> cert_header_sa6@...000 {
> arch/arm64/boot/dts/renesas/hihope-rev4.dtsi:      cs2000: clk_multiplier@4f {
> 
> No worries, will queue in renesas-devel for v6.20, with those fixed, too.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 


Best regards,
Krzysztof