linux-kernel - Re: [PATCH] mfd: stpmic1: Attempt system shutdown twice in case PMIC is confused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <444b4bc1-7724-4ea1-8e1e-8f5e7945eff2@nabladev.com>
Date: Fri, 9 Jan 2026 16:39:38 +0100
From: Marek Vasut <marex@...ladev.com>
To: Sean Nyekjaer <sean@...nix.com>
Cc: linux-kernel@...r.kernel.org, Lee Jones <lee@...nel.org>,
 Pascal PAILLET-LME <p.paillet@...com>, Paul Cercueil <paul@...pouillou.net>,
 kernel@...electronics.com
Subject: Re: [PATCH] mfd: stpmic1: Attempt system shutdown twice in case PMIC
 is confused

On 1/9/26 3:54 PM, Sean Nyekjaer wrote:
> On Fri, Jan 09, 2026 at 05:12:09AM +0100, Marek Vasut wrote:
>> Attempt to shut down again, in case the first attempt failed.
>> The STPMIC1 might get confused and the first regmap_update_bits()
>> returns with -ETIMEDOUT / -110 . If that or similar transient
>> failure occurs, try to shut down again. If the second attempt
>> fails, there is some bigger problem, report it to user.
> 
> I don't think I have ever seen my devices fail to shutdown.
> Have you ever seen the second call fail?
I have sporadically seen the first call fail with timeout, not the 
second one yet. If the second call fails, I think we have a real bad 
hardware problem.

Maybe these issues are hidden on devices which use SCMI too, so they 
never get properly fixed in the direct hardware access kernel drivers 
anymore, sigh.