linux-kernel - Re: [PATCH] mfd:tc3589:fix a potential resource leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260109154139.GA1808297@google.com>
Date: Fri, 9 Jan 2026 15:41:39 +0000
From: Lee Jones <lee@...nel.org>
To: Felix Gu <gu_0233@...com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd:tc3589:fix a potential resource leak

On Fri, 26 Dec 2025, Felix Gu wrote:

> Use devm_request_threaded_irq to repalce request_threaded_irq to avoid
> a potential resource leak.
> 
> Signed-off-by: Felix Gu <gu_0233@...com>
> ---
>  drivers/mfd/tc3589x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c
> index 2d4eb771e230..e3aaeb4701b8 100644
> --- a/drivers/mfd/tc3589x.c
> +++ b/drivers/mfd/tc3589x.c
> @@ -410,7 +410,7 @@ static int tc3589x_probe(struct i2c_client *i2c)
>  	if (ret)
>  		return ret;
>  
> -	ret = request_threaded_irq(tc3589x->i2c->irq, NULL, tc3589x_irq,
> +	ret = devm_request_threaded_irq(tc3589x->dev, tc3589x->i2c->irq, NULL, tc3589x_irq,
>  				   IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
>  				   "tc3589x", tc3589x);

These two lines no longer line-up.  Please fix.

>  	if (ret) {
> 
> ---
> base-commit: 3d845d25026c5b1050e927e3ee4c515977a9b490
> change-id: 20251226-tc3589x-fix-50ce3358c7bf
> 
> Best regards,
> -- 
> Felix Gu <gu_0233@...com>
> 

-- 
Lee Jones [李琼斯]