linux-kernel - [PATCH v2] mfd:tc3589:fix a potential resource leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_B020C4282210FCEB4C140D22B8A5E7C4C307@qq.com>
Date: Sat, 10 Jan 2026 00:27:44 +0800
From: Felix Gu <gu_0233@...com>
To: Lee Jones <lee@...nel.org>
Cc: linux-kernel@...r.kernel.org, Felix Gu <gu_0233@...com>
Subject: [PATCH v2] mfd:tc3589:fix a potential resource leak

Use devm_request_threaded_irq to repalce request_threaded_irq to avoid
a potential resource leak.

Signed-off-by: Felix Gu <gu_0233@...com>
---
Changes in v2:
- Fix format.
- Link to v1: https://lore.kernel.org/lkml/tencent_EFCFAE871E8872447FF88F99091A51701D08@qq.com/
---
 drivers/mfd/tc3589x.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c
index 2d4eb771e230..f673ee4e1d16 100644
--- a/drivers/mfd/tc3589x.c
+++ b/drivers/mfd/tc3589x.c
@@ -410,9 +410,10 @@ static int tc3589x_probe(struct i2c_client *i2c)
 	if (ret)
 		return ret;
 
-	ret = request_threaded_irq(tc3589x->i2c->irq, NULL, tc3589x_irq,
-				   IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
-				   "tc3589x", tc3589x);
+	ret = devm_request_threaded_irq(tc3589x->dev, tc3589x->i2c->irq, NULL,
+					tc3589x_irq,
+					IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+					"tc3589x", tc3589x);
 	if (ret) {
 		dev_err(tc3589x->dev, "failed to request IRQ: %d\n", ret);
 		return ret;

---
base-commit: 3d845d25026c5b1050e927e3ee4c515977a9b490
change-id: 20251226-tc3589x-fix-50ce3358c7bf

Best regards,
-- 
Felix Gu <gu_0233@...com>