| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAMuHMdWGf7MgFzxjuea8agZgSyAMzXwFYO22NmRZ7i1-VPzqFw@mail.gmail.com>
Date: Fri, 9 Jan 2026 18:59:12 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Tommaso Merciai <tommaso.merciai.xr@...renesas.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, tomm.merciai@...il.com,
linux-renesas-soc@...r.kernel.org, biju.das.jz@...renesas.com,
Andrzej Hajda <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>,
Robert Foss <rfoss@...nel.org>, Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Geert Uytterhoeven <geert+renesas@...der.be>, Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>, Magnus Damm <magnus.damm@...il.com>,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH 09/22] dt-bindings: display: bridge: renesas,dsi: Add
support for RZ/G3E SoC
Hi Tommaso,
On Fri, 9 Jan 2026 at 18:36, Tommaso Merciai
<tommaso.merciai.xr@...renesas.com> wrote:
> On Fri, Jan 09, 2026 at 05:22:02PM +0100, Geert Uytterhoeven wrote:
> > On Fri, 9 Jan 2026 at 17:06, Tommaso Merciai
> > <tommaso.merciai.xr@...renesas.com> wrote:
> > > On Sun, Nov 30, 2025 at 09:24:57AM +0100, Krzysztof Kozlowski wrote:
> > > > On 26/11/2025 15:07, Tommaso Merciai wrote:
> > > > > The MIPI DSI interface on the RZ/G3E SoC is nearly identical to that of
> > > > > the RZ/V2H(P) SoC, except that this have 2 input port and can use vclk1
> > > > > or vclk2 as DSI Video clock, depending on the selected port.
> > > > >
> > > > > To accommodate these differences, a SoC-specific
> > > > > `renesas,r9a09g047-mipi-dsi` compatible string has been added for the
> > > > > RZ/G3E SoC.
> > > > >
> > > > > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@...renesas.com>
> > > > > ---
> > > > > .../bindings/display/bridge/renesas,dsi.yaml | 120 +++++++++++++++---
> > > > > 1 file changed, 101 insertions(+), 19 deletions(-)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dsi.yaml b/Documentation/devicetree/bindings/display/bridge/renesas,dsi.yaml
> > > > > index c20625b8425e..9917b494a9c9 100644
> > > > > --- a/Documentation/devicetree/bindings/display/bridge/renesas,dsi.yaml
> > > > > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsi.yaml
> > > > > @@ -28,6 +28,7 @@ properties:
> > > > > - const: renesas,r9a09g057-mipi-dsi
> > > > >
> > > > > - enum:
> > > > > + - renesas,r9a09g047-mipi-dsi # RZ/G3E
> > > > > - renesas,r9a09g057-mipi-dsi # RZ/V2H(P)
> > > > >
> > > > > reg:
> > > > > @@ -84,6 +85,13 @@ properties:
> > > > > - const: pclk
> > > > > - const: vclk
> > > > > - const: lpclk
> > > > > + - items:
> > > > > + - const: pllrefclk
> > > > > + - const: aclk
> > > > > + - const: pclk
> > > > > + - const: vclk1
> > > > > + - const: vclk2
> > > > > + - const: lpclk
> > > >
> > > > Why are you creating completely new lists every time?
> > > >
> > > > No, come with unified approach.
> > >
> > > The intent is not to create a completely new clock list per IP, but to keep a
> > > unified clock definition that can scale with feature differences.
> > >
> > > The previous IP supports a single DSI input port, whereas this IP supports two
> > > DSI input ports.
> > >
> > > Because of this added capability, the hardware naturally introduced an
> > > additional clock.
> > >
> > > Can you please suggest how to handle it?
> >
> > Keep on calling the first vclk "vclk", and add "vclk2" at the end of the list?
> > Then RZ/V2H can specify the first 5 clocks, and RZ/G3E can specify all 6.
>
> Testing a bit your suggestion
> we can do:
>
> clock-names:
> oneOf:
> - items:
> - const: pllclk
> - const: sysclk
> - const: aclk
> - const: pclk
> - const: vclk
> - const: lpclk
> - minItems: 5
> items:
> - const: pllrefclk
> - const: aclk
> - const: pclk
> - const: vclk
> - const: lpclk
> - const: vclk2
>
> Then later into the compatible if switch we can do:
>
>
> - if:
> properties:
> compatible:
> contains:
> const: renesas,r9a09g047-mipi-dsi
> then:
> properties:
> clocks:
> items:
> - description: DSI PLL reference input clock
> - description: DSI AXI bus clock
> - description: DSI Register access clock
> - description: DSI Video clock
> - description: DSI D-PHY Escape mode transmit clock
> - description: DSI Video clock (2nd input clock)
All descriptions belong at the top level. Just add the 6th one.
> clock-names:
> minItems: 6
Exactly.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists