linux-kernel - Re: [PATCH] usb: host: xhci-tegra: Use platform_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <26c69151-6342-4504-933a-802dda910a83@nvidia.com>
Date: Fri, 9 Jan 2026 18:36:16 +0000
From: Jon Hunter <jonathanh@...dia.com>
To: Wei-Cheng Chen <weichengc@...dia.com>,
 Mathias Nyman <mathias.nyman@...el.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Thierry Reding <thierry.reding@...il.com>, Haotien Hsu <haotienh@...dia.com>
Cc: linux-usb@...r.kernel.org, linux-tegra@...r.kernel.org,
 linux-kernel@...r.kernel.org, Wayne Chang <waynec@...dia.com>
Subject: Re: [PATCH] usb: host: xhci-tegra: Use platform_get_irq_optional()
 for wake IRQs


On 08/01/2026 10:21, Wei-Cheng Chen wrote:
> From: Wayne Chang <waynec@...dia.com>
> 
> When some wake IRQs are disabled in the device tree, the corresponding
> interrupt entries are removed from DT. In such cases, the driver
> currently calls platform_get_irq(), which returns -ENXIO and logs
> an error like:
> 
>    tegra-xusb 3610000.usb: error -ENXIO: IRQ index 2 not found
> 
> However, not all wake IRQs are mandatory. The hardware can operate
> normally even if some wake sources are not defined in DT. To avoid this
> false alarm and allow missing wake IRQs gracefully, use
> platform_get_irq_optional() instead of platform_get_irq().
> 
> Fixes: 5df186e2ef11 ("usb: xhci: tegra: Support USB wakeup function for Tegra234")
> Signed-off-by: Wayne Chang <waynec@...dia.com>
> Signed-off-by: Wei-Cheng Chen <weichengc@...dia.com>
> ---
>   drivers/usb/host/xhci-tegra.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
> index 31ccced5125..8b492871d21 100644
> --- a/drivers/usb/host/xhci-tegra.c
> +++ b/drivers/usb/host/xhci-tegra.c
> @@ -1563,7 +1563,7 @@ static int tegra_xusb_setup_wakeup(struct platform_device *pdev, struct tegra_xu
>   	for (i = 0; i < tegra->soc->max_num_wakes; i++) {
>   		struct irq_data *data;
>   
> -		tegra->wake_irqs[i] = platform_get_irq(pdev, i + WAKE_IRQ_START_INDEX);
> +		tegra->wake_irqs[i] = platform_get_irq_optional(pdev, i + WAKE_IRQ_START_INDEX);
>   		if (tegra->wake_irqs[i] < 0)
>   			break;
>   

Reviewed-by: Jon Hunter <jonathanh@...dia.com>
Tested-by: Jon Hunter <jonathanh@...dia.com>

Thanks!
Jon

-- 
nvpublic