linux-kernel - Re: [PATCH v2 01/11] mm/migrate_device: Introduce migrate_pfn_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3334cea8-dbaf-4dce-8b6f-e22350f642b2@amd.com>
Date: Fri, 9 Jan 2026 16:03:59 -0500
From: "Kuehling, Felix" <felix.kuehling@....com>
To: Jordan Niethe <jniethe@...dia.com>, linux-mm@...ck.org
Cc: balbirs@...dia.com, matthew.brost@...el.com, akpm@...ux-foundation.org,
 linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 david@...hat.com, ziy@...dia.com, apopple@...dia.com,
 lorenzo.stoakes@...cle.com, lyude@...hat.com, dakr@...nel.org,
 airlied@...il.com, simona@...ll.ch, rcampbell@...dia.com,
 mpenttil@...hat.com, jgg@...dia.com, willy@...radead.org,
 linuxppc-dev@...ts.ozlabs.org, intel-xe@...ts.freedesktop.org, jgg@...pe.ca
Subject: Re: [PATCH v2 01/11] mm/migrate_device: Introduce
 migrate_pfn_from_page() helper


On 2026-01-08 18:49, Jordan Niethe wrote:
> Hi,
>
> On 9/1/26 07:03, Felix Kuehling wrote:
>>
>>> @@ -646,7 +646,7 @@ svm_migrate_copy_to_ram(struct amdgpu_device 
>>> *adev, struct svm_range *prange,
>>>           pr_debug_ratelimited("dma mapping dst to 0x%llx, pfn 
>>> 0x%lx\n",
>>>                        dst[i] >> PAGE_SHIFT, page_to_pfn(dpage));
>>> -        migrate->dst[i] = migrate_pfn(page_to_pfn(dpage));
>>> +        migrate->dst[i] = migrate_pfn_from_page(dpage);
>>
>> You missed another instance of this in svm_migrate_copy_to_vram.
>
> I might be missing something, but is there call to migrate_pfn() in
> svm_migrate_copy_to_vram()? 

I see what's happening. You removed that call in patch 2. Never mind.

Regards,
   Felix


> I'm seeing svm_migrate_copy_to_vram() calls
> svm_migrate_addr_to_mpfn() - that should be handled already.
>
> Thanks for reviewing,
> Jordan.
>
>>
>> Regards,
>>    Felix
>>
>>