linux-kernel - Re: [v2] drm/amdkfd: fix a memory leak in device_queue_manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc26748a-3ef4-4b7c-9772-8dd7a7f03364@amd.com>
Date: Fri, 9 Jan 2026 16:16:47 -0500
From: "Kuehling, Felix" <felix.kuehling@....com>
To: Markus Elfring <Markus.Elfring@....de>,
 Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>, amd-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 David Airlie <airlied@...il.com>, Oak Zeng <ozeng@....com>,
 Simona Vetter <simona@...ll.ch>
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [v2] drm/amdkfd: fix a memory leak in device_queue_manager_init()

On 2026-01-09 03:37, Markus Elfring wrote:
>> My conclusion is that this WARN is just unnecessary.
> Would you like to omit such a questionable macro call then?

I don't feel strongly about it. I already submitted Haoxiang's patch.


>
>
>> But it's also harmless.
> How do you think about to avoid special development concerns here?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.19-rc4#n1242

No. I think the WARN is used exactly as it was meant to be here: to 
check for something that should never happen.

Regards,
   Felix


>
> Regards,
> Markus