linux-kernel - Re: [PATCH v2] audit: sort missing compat prototypes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b1174bc8641f6738a1b82b237bebe68e@paul-moore.com>
Date: Fri, 09 Jan 2026 16:37:57 -0500
From: Paul Moore <paul@...l-moore.com>
To: Ben Dooks <ben.dooks@...ethink.co.uk>, linux-kernel@...r.kernel.org, audit@...r.kernel.org
Cc: eparis@...hat.com, Ben Dooks <ben.dooks@...ethink.co.uk>
Subject: Re: [PATCH v2] audit: sort missing compat prototypes

On Jan  9, 2026 Ben Dooks <ben.dooks@...ethink.co.uk> wrote:
> 
> The comapt_xxx_class symbols aren't declared in anything that
> lib/comapt_audit.c is including (arm64 build) which is causing
> the following sparse warnings:
> 
> lib/compat_audit.c:7:10: warning: symbol 'compat_dir_class' was not declared. Should it be static?
> lib/compat_audit.c:12:10: warning: symbol 'compat_read_class' was not declared. Should it be static?
> lib/compat_audit.c:17:10: warning: symbol 'compat_write_class' was not declared. Should it be static?
> lib/compat_audit.c:22:10: warning: symbol 'compat_chattr_class' was not declared. Should it be static?
> lib/compat_audit.c:27:10: warning: symbol 'compat_signal_class' was not declared. Should it be static?
> 
> Trying to fix this by chaning compat_audit.c to inclde <linux/audit.h>
> does not work on arm64 due to compile errors with the extra includes
> that changing this header makes. The simpler thing would be just to
> move the definitons of these symbols out of <linux/audit.h> into
> <linux/audit_arch.h> which is included.
> 
> Fixes: 4b58841149dca ("audit: Add generic compat syscall support")
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> ---
> v2: fixed missed commit of include/linux/audit.h
> ---
>  include/linux/audit.h      | 6 ------
>  include/linux/audit_arch.h | 7 +++++++
>  2 files changed, 7 insertions(+), 6 deletions(-)

I merged this into audit/dev, but I rewrote the subject line to "audit:
move the compat_xxx_class[] extern declarations to audit_arch.h" properly
reflect the change in the patch, and wrapped the compiler output examples
so that 'git log' on an 80-char wide terminal is not overly ugly.  Please
take this into account in future patch submissions, thanks.

--
paul-moore.com