linux-kernel - Re: [PATCH v17 19/32] x86/resctrl: Find and enable usable telemetry events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260109220157.GHaWF61bNih09Om04i@fat_crate.local>
Date: Fri, 9 Jan 2026 23:01:57 +0100
From: Borislav Petkov <bp@...en8.de>
To: "Luck, Tony" <tony.luck@...el.com>,
	Reinette Chatre <reinette.chatre@...el.com>
Cc: Fenghua Yu <fenghuay@...dia.com>,
	Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>,
	Peter Newman <peternewman@...gle.com>,
	James Morse <james.morse@....com>, Babu Moger <babu.moger@....com>,
	Drew Fustini <dfustini@...libre.com>,
	Dave Martin <Dave.Martin@....com>, Chen Yu <yu.c.chen@...el.com>,
	x86@...nel.org, linux-kernel@...r.kernel.org,
	patches@...ts.linux.dev,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Subject: Re: [PATCH v17 19/32] x86/resctrl: Find and enable usable telemetry
 events

On Fri, Jan 09, 2026 at 08:53:09AM -0800, Luck, Tony wrote:
> This was made a separate function in response to a comment against the
> v9 series from Ilpo:
> 
> 	As this is at least semi-hacky, I suggest you move it into own function 
> 	and add a bit longer comment to the function (along the lines what the 
> 	changelog also states why it works).
> 
> Link: https://lore.kernel.org/all/3b0546d4-d0bc-f76e-e1c2-eef2b4abf0f1@linux.intel.com/
> 
> But at that point the "p->regions[i].addr = NULL;" was part of a much
> larger function. Since then refactoring into various helpers means that
> it now looks OK to move it inline. The comment about why it is safe to
> update a structure that was provided by Intel-PMT driver is the
> important bit, and I see that you preserved that.
> 
> So LGTM

Thank you both!

/me folds in.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette