Message-ID: <c554baf7-cb61-4003-8f72-bd0c9b39f133@kaod.org>
Date: Fri, 9 Jan 2026 23:05:52 +0100
From: Cédric Le Goater <clg@...d.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Mark Brown
	<broonie@...nel.org>, Varshini Rajendran <varshini.rajendran@...rochip.com>,
	Mikhail Kshevetskiy <mikhail.kshevetskiy@...sys.eu>, "AngeloGioacchino Del
 Regno" <angelogioacchino.delregno@...labora.com>, Sunny Luo
	<sunny.luo@...ogic.com>, Janne Grunau <j@...nau.net>, Chin-Ting Kuo
	<chin-ting_kuo@...eedtech.com>, CL Wang <cl634@...estech.com>, "Manikandan
 Muralidharan" <manikandan.m@...rochip.com>, David Lechner
	<dlechner@...libre.com>, Florian Fainelli <florian.fainelli@...adcom.com>,
	Jonas Gorski <jonas.gorski@...il.com>, Hang Zhou <929513338@...com>, Jun Guo
	<jun.guo@...tech.com>, Philipp Stanner <phasta@...nel.org>, Charles Keepax
	<ckeepax@...nsource.cirrus.com>, Bartosz Golaszewski <brgl@...nel.org>,
	Benoît Monin <benoit.monin@...tlin.com>, Shiji Yang
	<yangshiji66@...look.com>, James Clark <james.clark@...aro.org>, "Jonathan
 Marek" <jonathan@...ek.ca>, Carlos Song <carlos.song@....com>, Sakari Ailus
	<sakari.ailus@...ux.intel.com>, Huacai Chen <chenhuacai@...nel.org>, "Xianwei
 Zhao" <xianwei.zhao@...ogic.com>, Prajna Rajendra Kumar
	<prajna.rajendrakumar@...rochip.com>, Sergio Perez Gonzalez
	<sperezglz@...il.com>, Miquel Raynal <miquel.raynal@...tlin.com>, "Qianfeng
 Rong" <rongqianfeng@...o.com>, Haibo Chen <haibo.chen@....com>, Gabor Juhos
	<j4g8y7@...il.com>, Md Sadre Alam <quic_mdalam@...cinc.com>, Rosen Penev
	<rosenp@...il.com>, Luis de Arquer <luis.dearquer@...rtim.com>, "Geert
 Uytterhoeven" <geert+renesas@...der.be>, Cosmin Tanislav
	<cosmin-gabriel.tanislav.xa@...esas.com>, Tudor Ambarus
	<tudor.ambarus@...aro.org>, Krzysztof Kozlowski <krzk@...nel.org>, Longbin Li
	<looong.bin@...il.com>, Patrice Chotard <patrice.chotard@...s.st.com>,
	Clément Le Goffic <clement.legoffic@...s.st.com>,
	"Alessandro Grassi" <alessandro.grassi@...lbox.org>, Chen-Yu Tsai
	<wens@...nel.org>, Darshan R <rathod.darshan.0896@...il.com>, Aaron Kling
	<webgeek1234@...il.com>, Vishwaroop A <va@...dia.com>, Haixu Cui
	<quic_haixcui@...cinc.com>, Darshan Rathod <darshanrathod475@...il.com>,
	<linux-spi@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <linux-amlogic@...ts.infradead.org>,
	<asahi@...ts.linux.dev>, <linux-aspeed@...ts.ozlabs.org>,
	<openbmc@...ts.ozlabs.org>, <linux-rpi-kernel@...ts.infradead.org>,
	<linux-sound@...r.kernel.org>, <patches@...nsource.cirrus.com>,
	<imx@...ts.linux.dev>, <linux-arm-msm@...r.kernel.org>,
	<linux-riscv@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org>,
	<linux-rockchip@...ts.infradead.org>, <linux-renesas-soc@...r.kernel.org>,
	<linux-samsung-soc@...r.kernel.org>,
	<linux-stm32@...md-mailman.stormreply.com>, <linux-sunxi@...ts.linux.dev>,
	<linux-tegra@...r.kernel.org>, <virtualization@...ts.linux.dev>
CC: Nicolas Ferre <nicolas.ferre@...rochip.com>, Alexandre Belloni
	<alexandre.belloni@...tlin.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
	Lorenzo Bianconi <lorenzo@...nel.org>, Ray Liu <ray.liu@...oha.com>, "Sven
 Peter" <sven@...nel.org>, Neal Gompa <neal@...pa.dev>, Joel Stanley
	<joel@....id.au>, Andrew Jeffery <andrew@...econstruct.com.au>, Ryan Wanner
	<ryan.wanner@...rochip.com>, Michael Hennerich
	<michael.hennerich@...log.com>, Nuno Sá
	<nuno.sa@...log.com>, Kamal Dasu <kamal.dasu@...adcom.com>, "Broadcom
 internal kernel review list" <bcm-kernel-feedback-list@...adcom.com>, Ray Jui
	<rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, William Zhang
	<william.zhang@...adcom.com>, Kursad Oney <kursad.oney@...adcom.com>, "Anand
 Gore" <anand.gore@...adcom.com>, Rafał Miłecki
	<rafal@...ecki.pl>, David Rhodes <david.rhodes@...rus.com>, "Richard
 Fitzgerald" <rf@...nsource.cirrus.com>, Vladimir Oltean <olteanv@...il.com>,
	Frank Li <Frank.Li@....com>, Jean-Marie Verdun <verdun@....com>, Nick Hawkins
	<nick.hawkins@....com>, Yang Shen <shenyang39@...wei.com>, Shawn Guo
	<shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, "Pengutronix
 Kernel Team" <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>,
	"Lixu Zhang" <lixu.zhang@...el.com>, Yinbo Zhu <zhuyinbo@...ngson.cn>, "Neil
 Armstrong" <neil.armstrong@...aro.org>, Kevin Hilman <khilman@...libre.com>,
	Jerome Brunet <jbrunet@...libre.com>, Martin Blumenstingl
	<martin.blumenstingl@...glemail.com>, Conor Dooley
	<conor.dooley@...rochip.com>, Daire McNamara <daire.mcnamara@...rochip.com>,
	Matthias Brugger <matthias.bgg@...il.com>, Avi Fishman
	<avifishman70@...il.com>, Tomer Maimon <tmaimon77@...il.com>, Tali Perry
	<tali.perry1@...il.com>, Patrick Venture <venture@...gle.com>, Nancy Yuen
	<yuenn@...gle.com>, Benjamin Fair <benjaminfair@...gle.com>, Han Xu
	<han.xu@....com>, Yogesh Gaur <yogeshgaur.83@...il.com>, Linus Walleij
	<linusw@...nel.org>, Daniel Mack <daniel@...que.org>, Haojian Zhuang
	<haojian.zhuang@...il.com>, Robert Jarzmik <robert.jarzmik@...e.fr>, "Chris
 Packham" <chris.packham@...iedtelesis.co.nz>, Heiko Stuebner
	<heiko@...ech.de>, Fabrizio Castro <fabrizio.castro.jz@...esas.com>, "Andi
 Shyti" <andi.shyti@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>, "Paul
 Walmsley" <pjw@...nel.org>, Samuel Holland <samuel.holland@...ive.com>,
	"Orson Zhai" <orsonzhai@...il.com>, Baolin Wang
	<baolin.wang@...ux.alibaba.com>, Chunyan Zhang <zhang.lyra@...il.com>, Maxime
 Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue
	<alexandre.torgue@...s.st.com>, Alain Volmat <alain.volmat@...s.st.com>,
	Jernej Skrabec <jernej.skrabec@...il.com>, Li-hao Kuo <lhjeff911@...il.com>,
	Masahisa Kojima <masahisa.kojima@...aro.org>, Jassi Brar
	<jaswinder.singh@...aro.org>, "Laxman Dewangan" <ldewangan@...dia.com>,
	Thierry Reding <thierry.reding@...il.com>, Jonathan Hunter
	<jonathanh@...dia.com>, Sowjanya Komatineni <skomatineni@...dia.com>,
	Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>, Masami Hiramatsu
	<mhiramat@...nel.org>, Jonathan Neuschäfer
	<j.neuschaefer@....net>, Michal Simek <michal.simek@....com>, Max Filippov
	<jcmvbkbc@...il.com>
Subject: Re: [PATCH v1 2/4] spi: Drop duplicate of_node assignment

On 1/8/26 21:23, Andy Shevchenko wrote:
> The SPI core provides the default of_node for the controller,
> inherited from the actual (parent) device. No need to repeat it
> in the driver.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/spi/atmel-quadspi.c          | 1 -
>   drivers/spi/spi-altera-platform.c    | 2 --
>   drivers/spi/spi-amlogic-spifc-a1.c   | 1 -
>   drivers/spi/spi-amlogic-spisg.c      | 1 -
>   drivers/spi/spi-apple.c              | 1 -
>   drivers/spi/spi-ar934x.c             | 1 -
>   drivers/spi/spi-armada-3700.c        | 4 +---
>   drivers/spi/spi-aspeed-smc.c         | 1 -
For aspeed,

Reviewed-by: Cédric Le Goater <clg@...d.org>

Thanks,

C.

Powered by blists - more mailing lists