[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20260109225608-GYA8877@gentoo.org>
Date: Sat, 10 Jan 2026 06:56:08 +0800
From: Yixun Lan <dlan@...too.org>
To: Guodong Xu <guodong@...cstar.com>
Cc: Linus Walleij <linusw@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Troy Mitchell <troy.mitchell@...ux.spacemit.com>,
linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/4] dt-bindings: pinctrl: spacemit: add K3 SoC support
Hi Guodong,
On 20:20 Fri 09 Jan , Guodong Xu wrote:
> Hi, Yixun
>
> On Fri, Jan 2, 2026 at 3:04 PM Yixun Lan <dlan@...too.org> wrote:
> >
> > Add new compatible string for SpacemiT K3 SoC, the pinctrl IP shares
> > almost same logic with previous K1 generation, but has different register
> > offset and pin configuration, for example the drive strength and
> > schmitter trigger settings has been changed.
> >
> > Signed-off-by: Yixun Lan <dlan@...too.org>
> > ---
> > .../devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml | 10 +++++++++-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml
> > index 609d7db97822..9a76cffcbaee 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml
> > @@ -81,6 +83,12 @@ patternProperties:
> > - enum: [ 7, 10, 13, 16, 19, 23, 26, 29 ]
> > description: For K1 SoC, 3.3V voltage output
> >
> > + - enum: [ 2, 4, 6, 7, 9, 11, 13, 14, 21, 23, 25, 26, 28, 30, 31, 33 ]
> > + description: For K3 SoC, 1.8V voltage output
> > +
..
> > + - enum: [ 3, 5, 7, 9, 11, 13, 15, 17, 25, 27, 29, 31, 33, 35, 37, 38 ]
> > + description: For K3 SoC, 1.8V voltage output
>
> Should one of these be 3.3V? Both descriptions currently specify 1.8V.
>
right, the latter one should be changed to 3.3V, I will send a patch
to fix this.
--
Yixun Lan (dlan)
Powered by blists - more mailing lists