linux-kernel - Re: [PATCH 2/4] perf test: Use shelldir to refer perf source location

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fWaYs5HL2T=zHdr-W2h5j74UaCtxqa-FC9Dm_y+F+VpFQ@mail.gmail.com>
Date: Fri, 9 Jan 2026 15:17:46 -0800
From: Ian Rogers <irogers@...gle.com>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>, James Clark <james.clark@...aro.org>, 
	Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>, 
	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...nel.org>, 
	LKML <linux-kernel@...r.kernel.org>, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 2/4] perf test: Use shelldir to refer perf source location

On Thu, Dec 18, 2025 at 5:18 PM Namhyung Kim <namhyung@...nel.org> wrote:
>
> It uses tools/perf/include which assumes it's running from the root of
> the linux kernel source tree.  But you can run perf from other places
> like tools/perf, then the include path won't match.  We can use the
> shelldir variable to locate the test script in the tree.
>
>   $ cd tools/perf
>
>   $ ./perf test dlfilter
>    63: dlfilter C API                                                  : Ok
>   101: perf script --dlfilter tests                                    : Ok
>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/tests/shell/script_dlfilter.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/shell/script_dlfilter.sh b/tools/perf/tests/shell/script_dlfilter.sh
> index 7895ab0309b29dd5..aaed92bb78285dfd 100755
> --- a/tools/perf/tests/shell/script_dlfilter.sh
> +++ b/tools/perf/tests/shell/script_dlfilter.sh
> @@ -68,7 +68,7 @@ test_dlfilter() {
>         fi
>
>         # Build the dlfilter
> -       if ! cc -c -I tools/perf/include -fpic -x c "${dlfilter_c}" -o "${dlfilter_so}.o"
> +       if ! cc -c -I ${shelldir}/../../include -fpic -x c "${dlfilter_c}" -o "${dlfilter_so}.o"
>         then
>                 echo "Basic --dlfilter test [Skip - failed to build dlfilter object]"
>                 err=2
> --
> 2.52.0.322.g1dd061c0dc-goog
>