linux-kernel - Re: [PATCH v2 1/3] staging: rtl8723bs: fix firmware memory leak on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWCc0Mq_m_1lKI7H@stanley.mountain>
Date: Fri, 9 Jan 2026 09:14:40 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Samasth Norway Ananda <samasth.norway.ananda@...cle.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] staging: rtl8723bs: fix firmware memory leak on
 error

On Thu, Jan 08, 2026 at 10:16:09AM -0800, Samasth Norway Ananda wrote:
> After successfully calling request_firmware(), if the firmware size
> check fails or if kmemdup() fails, the code jumps to the exit label
> without calling release_firmware(), causing a memory leak. Call
> release_firmware() directly in each error path before jumping to cleanup
> label.
> 
> Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@...cle.com>

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter