linux-kernel - Re: [PATCH v2 3/9] dt-bindings: clock: gcc-ipq9574: add wcss remoteproc clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260109-simple-smooth-basilisk-ab8df6@quoll>
Date: Fri, 9 Jan 2026 09:39:47 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alexandru Gagniuc <mr.nuke.me@...il.com>
Cc: andersson@...nel.org, krzk+dt@...nel.org, mturquette@...libre.com, 
	linux-remoteproc@...r.kernel.org, Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, mathieu.poirier@...aro.org, konradybcio@...nel.org, 
	p.zabel@...gutronix.de, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v2 3/9] dt-bindings: clock: gcc-ipq9574: add wcss
 remoteproc clocks

On Thu, Jan 08, 2026 at 10:33:38PM -0600, Alexandru Gagniuc wrote:
> Commit da040d560319 ("dt-bindings: clock: qcom: gcc-ipq9574: remove q6
> bring up clock macros") removed these clocks on the idea that Q6
> firmware is responsible for clock bringup. That statement seems
> incorrect, as these clocks need to be enabled before the Q6 is booted.
> Otherwise, the host CPU core that starts the Q6 hangs.
> 
> Perhaps the statement meant that the TrustZone firmware will start the
> clocks. This only happens in PAS mode. Under native OS loading, the
> host needs these clocks, so add them back.
> 
> Besides the clocks that were erroneously removed, also add defines for
> GCC_WCSS_AHB_S_CLK, GCC_WCSS_AXI_M_CLK, and GCC_Q6_AXIM2_CLK, as all
> these clocks are required to operate the remoteproc.
> 
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@...il.com>
> ---
>  include/dt-bindings/clock/qcom,ipq9574-gcc.h | 22 ++++++++++++++++++++
>  1 file changed, 22 insertions(+)

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>

Best regards,
Krzysztof