linux-kernel - Re: [PATCH v5 11/24] scsi: ufs: mediatek: Rework probe function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46cb450f92887ceba07614dc85ed495f6af7f602.camel@mediatek.com>
Date: Fri, 9 Jan 2026 09:16:33 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "chu.stanley@...il.com" <chu.stanley@...il.com>, "robh@...nel.org"
	<robh@...nel.org>, Chunfeng Yun (云春峰)
	<Chunfeng.Yun@...iatek.com>, "kishon@...nel.org" <kishon@...nel.org>,
	"James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>, "bvanassche@....org"
	<bvanassche@....org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>,
	Chaotian Jing (井朝天)
	<Chaotian.Jing@...iatek.com>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"nicolas.frattaroli@...labora.com" <nicolas.frattaroli@...labora.com>,
	"vkoul@...nel.org" <vkoul@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"alim.akhtar@...sung.com" <alim.akhtar@...sung.com>, "krzk@...nel.org"
	<krzk@...nel.org>, "neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>, "avri.altman@....com"
	<avri.altman@....com>, "broonie@...nel.org" <broonie@...nel.org>,
	"martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-phy@...ts.infradead.org"
	<linux-phy@...ts.infradead.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, Louis-Alexis Eyraud
	<louisalexis.eyraud@...labora.com>, "kernel@...labora.com"
	<kernel@...labora.com>
Subject: Re: [PATCH v5 11/24] scsi: ufs: mediatek: Rework probe function

On Fri, 2026-01-09 at 09:43 +0100, Krzysztof Kozlowski wrote:
> On 09/01/2026 09:38, Peter Wang (王信友) wrote:
> > On Fri, 2026-01-09 at 08:24 +0100, Krzysztof Kozlowski wrote:
> > > On 09/01/2026 07:22, Peter Wang (王信友) wrote:
> > > > 
> > > > 
> > > > Is it sufficient for us to supplement the ABI document?
> > > > This ABI might affect the ability to reset and recover after 
> > > > an UFS error in upstream world.
> > > 
> > > 
> > > In normal case yes, but I cannot imagine arguments justifying
> > > your
> > > usage
> > > of TI properties. Basically it would not pass review.
> > > 
> > > Best regards,
> > > Krzysztof
> > 
> > 
> > Yes, this part is indeed because MediaTek’s reset hardware 
> > implementation is the same as TI’s. That’s why we used “compatible”
> > instead of actually implementing MediaTek’s own reset controller.
> 
> So that's another purely downstream code. Additionally very poor
> quality
> downstream code.
> 
> > So, are you suggesting that we upstream a MediaTek reset
> > controller,
> > even though the code is almost identical to TI’s?
> 
> If you ask about DT, this is already answered in writing bindings
> document. You cannot use someone else's compatible. Was also re-
> iterated
> on mailing list bazillions of times.
> 
> Best regards,
> Krzysztof

Okay, we will correct these incorrect usages.

Thanks
Peter