linux-kernel - Re: [PATCH v5 3/4] i2c: tegra: Add logic to support different register offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <650d72a0-cdd2-4c24-adca-40196b265c7b@nvidia.com>
Date: Fri, 9 Jan 2026 09:50:18 +0000
From: Jon Hunter <jonathanh@...dia.com>
To: Kartik Rajput <kkartik@...dia.com>, ldewangan@...dia.com,
 digetx@...il.com, andi.shyti@...nel.org, thierry.reding@...il.com,
 akhilrajeev@...dia.com, smangipudi@...dia.com, linux-i2c@...r.kernel.org,
 linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 3/4] i2c: tegra: Add logic to support different
 register offsets


On 08/01/2026 08:53, Jon Hunter wrote:

...

> Thinking about this some more I had a tough time reviewing this and feel 
> that this transition is error prone. I would prefer if we kept the 
> current definitions and then just ...
> 
> static const struct tegra_i2c_regs tegra20_i2c_regs = {
>      .cnfg = I2C_CNFG,
>      ...
> };
> 
> static const struct tegra_i2c_regs tegra20_dvc_i2c_regs = {
>      .cnfg = DVC_OFFSET(I2C_CNFG),
>      ...
> };
> 
> static const struct tegra_i2c_regs tegra210_vi_i2c_regs = {
>      .cnfg = VI_OFFSET(I2C_CNFG),
>      ...
> };


I spoke to Thierry and his preference is to get rid of the definitions 
and use the raw value in the structure. That is fine, but we should make 
sure these structures are created with the correct data.

Jon

-- 
nvpublic