[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CABFUUZGinC04zPEtwq3+maN-iNVNdc1p_BFnTdPNTsLXcQ1hnA@mail.gmail.com>
Date: Fri, 9 Jan 2026 10:08:20 +0800
From: sun jian <sun.jian.kdev@...il.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Shuah Khan <shuah@...nel.org>, David Hildenbrand <david@...nel.org>, linux-kselftest@...r.kernel.org,
linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/mm: run_vmtests.sh: fix relative path handling
> hm, why? Is that a thing people actually do?
>
> Is anyone going to actually test this feature?
Yes — invoking selftests directly from the kernel root can easily happen in
practice, for example::
sudo tools/testing/selftests/mm/run_vmtests.sh
This currently results in false failures because relative paths being resolved
against the caller's cwd instead of the script directory.
>
> Alternatively we could check that we're in the correct directory and
> error out if not.
That would also be reasonable, but I slightly prefer auto-cd because it
avoids an easy invocation pitfall and makes the runner more robust for
wrappers/CI
where the cwd is not stable. That said, I'm happy to switch to a fail-fast cwd
check if you prefer the behavior.
Regards,
Sun
Powered by blists - more mailing lists