linux-kernel - Re: [PATCH next] phy: apple: atc: Reset USB2 PHY during probe as well

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260109101915.GD4068972@robin.jannau.net>
Date: Fri, 9 Jan 2026 11:19:15 +0100
From: Janne Grunau <j@...nau.net>
To: Sven Peter <sven@...nel.org>
Cc: Neal Gompa <neal@...pa.dev>, Vinod Koul <vkoul@...nel.org>,
	Neil Armstrong <neil.armstrong@...aro.org>, asahi@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-phy@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	James Calligeros <jcalligeros99@...il.com>
Subject: Re: [PATCH next] phy: apple: atc: Reset USB2 PHY during probe as well

On Thu, Jan 08, 2026 at 08:12:06PM +0100, Sven Peter wrote:
> Now that the upstream Type-C PHY code is getting broader test coverage we
> got reports of USB devices plugged in during boot or those plugged in for
> the first time after boot occasionally not working correctly.
> This is partially caused by the USB2 parts of the PHY being left in an
> unknown state by the previous boot stages. We reset all other parts during
> probe but forgot about the USB2 PHY so let's fix that and actually reset
> and power off the USB2 PHY as well.
> 
> Reported-by: James Calligeros <jcalligeros99@...il.com>
> Reported-by: Janne Grunau <j@...nau.net>
> Fixes: 8e98ca1e74db ("phy: apple: Add Apple Type-C PHY")
> Signed-off-by: Sven Peter <sven@...nel.org>
> ---
>  drivers/phy/apple/atc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/apple/atc.c b/drivers/phy/apple/atc.c
> index c8a58ee64b7aad3205df51cf16ae778471ad2c5d..ab0b40b72533f1b3878b646b59820c730239e85c 100644
> --- a/drivers/phy/apple/atc.c
> +++ b/drivers/phy/apple/atc.c
> @@ -2227,6 +2227,7 @@ static int atcphy_probe_finalize(struct apple_atcphy *atcphy)
>  	_atcphy_dwc3_reset_assert(atcphy);
>  
>  	/* Reset atcphy to clear any state potentially left by the bootloader */
> +	atcphy_usb2_power_off(atcphy);
>  	atcphy_power_off(atcphy);
>  	atcphy_setup_pipehandler(atcphy);

Reviewed-by: Janne Grunau <j@...nau.net>
Tested-by: Janne Grunau <j@...nau.net>

thanks,

Janne