linux-kernel - Re: [PATCH v2 1/1] sched_ext: Add error logging for dsq creation failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWDhi0l1mHxjCg-H@gpd4>
Date: Fri, 9 Jan 2026 12:07:55 +0100
From: Andrea Righi <arighi@...dia.com>
To: George Guo <dongtai.guo@...ux.dev>
Cc: changwoo@...lia.com, etsal@...a.com, guodongtai@...inos.cn,
	linux-kernel@...r.kernel.org, sched-ext@...ts.linux.dev,
	tj@...nel.org, void@...ifault.com
Subject: Re: [PATCH v2 1/1] sched_ext: Add error logging for dsq creation
 failures

On Fri, Jan 09, 2026 at 06:39:16PM +0800, George Guo wrote:
> > Huh? No, we already get an error message both in dmesg and in stdout when
> > scx_bpf_create_dsq() fails, so I don't think this is required.
> > 
> > Are you sure you were not hitting other issues when your scheduler failed
> > to load silently?
> 
> 
> Hi Andrea,
> Here take an instance.
> You need add bpf_printk in BPF_STRUCT_OPS_SLEEPABLE(central_init), 
> even with dmesg when central_init fails, as central_init have multiply
> error return.

Ok, then maybe we can add a bit more information to the error message,
printing which DSQ failed to be created, for example:

 scx_bpf_error("failed to create DSQ %d (%d)", SHARED_DSQ, ret);

This would be more helpful I think.

Thanks,
-Andrea